optimize - #23
Open
HEIHUAa wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the last code optimization, I've been making changes here and there, and now it's time to summarize them.
Optimized operations like
x += 1: previously they would allocate a closure (creating a temporary function) andxwould require two variable lookups. Now it's directly cached, no closure allocation is needed, and it's about 35% faster.Previously, in
for (i in 0...10), a variable object was recreated after each loop iteration. Now it's reused.Optimized reading engine object fields: previously it had to check twice whether it was a special script object each time. Now the result is cached directly, improving speed by about 16%.
Optimized creating many instances of the same object with
new: specifically, instead of doing a table lookup every time, the result is now cached. Creating the same object 10,000 times is about 20% faster.Improved the speed of reading fields that are originally null, such as
FlxG.save.data.xxx, by about 15% (only forhscriptPos).Previously, function parameter declarations + loop variables + locals would all create a new internal record object. Now they are reused.
Merged the two sets of code for
assign/evalAssignOpto remove duplication.