Repository navigation
ci(website): harden the verify workflow, remove stray files, refresh the roadmap - #73
Merged
Merged
Conversation
- ci(website): add the test:support step to verify - ci(website): skip the pull_request run for dev-headed promotion PRs, since the dev push run already reports verify on that commit - ci(website): drop the unused feature/** push trigger - ci(website): cancel superseded PR runs with a concurrency group
…junk - refactor(repo): delete visual-schedule-manager-portfolio/, an unrelated app last touched 2025-08-20 that nothing in frontend/ or CI references - refactor(repo): delete root start.sh, the pre-Vercel dev launcher - chore(repo): drop two tracked scratch files under logs/
… 3D items - docs(roadmap): add a where-things-stand section covering the security patch, CI hardening and repo cleanup in flight - docs(roadmap): mark the WebGL fallback superseded by the Catalogue redesign and park the 3D asset set - docs(roadmap): record the PostHog verification of $pathname and $pageleave
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe pull request updates website workflow behavior and tests, records roadmap and analytics status, and removes the standalone visual schedule manager, its project files, the root development launcher, and an audit JSON file. ChangesWebsite verification and project status
Visual schedule manager removal
Priority: Estimated code review effort: 4 (Complex) | ~60 minutes Change: Other Possibly related PRs
Merge Risk:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (2 skipped: 2… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly summarizes the pull request’s three main changes: hardening the website verification workflow, removing unused repository files, and updating the roadmap. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 Biome (2.5.15)
-
frontend/test/workflow.test.mjs
-
Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Collaborator
Author
|
@coderabbitai review |
|
A queued push run shares its group with the running one, so a third push to dev replaced the pending run and left that SHA with no verify result. The promotion skip assumes every dev SHA keeps its own run. Keying push runs by run_id removes the queue; PR runs still cancel superseded heads per PR.
Collaborator
Author
|
@coderabbitai review |
✅ Action performed
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔇 Additional comments: 4
.github/workflows/website.yml: 2
16-21: LGTM!Also applies to: 34-38, 49-50, 55-56
26-26: 🎯 Functional CorrectnessThe promotion risk depends on unavailable branch rules.
The condition skips
verifyfor internaldev-to-mainpull requests. Whether this permits an untested merge depends onmainrequiring up-to-date branches or using a merge queue. The available evidence does not establish that repository setting.frontend/test/workflow.test.mjs: 1
1-53: LGTM!ROADMAP.md-51-51: 1
51-51:Minor · Maintainability & Code Quality · Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Use
anymorein this sentence.Replace “isn't on the critical path any more” with “isn't on the critical path anymore”.
Source: Linters/SAST tools
-
-
- Source mode: Auto
- Repository: CodesWhat/codeswhat.com
- Branch: ci/verify-capacity
- File: .coderabbit.yaml
- Commit: f3ea2d7
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
6056b6c0-8828-44b8-9d1b-832eac105356
-
logs/mcp-puppeteer-2025-12-10.logis excluded by!**/*.logvisual-schedule-manager-portfolio/assets/integrations/fyle_favicon.pngis excluded by!**/*.pngvisual-schedule-manager-portfolio/assets/integrations/onelogin_favicon.pngis excluded by!**/*.pngvisual-schedule-manager-portfolio/assets/integrations/sage_favicon.pngis excluded by!**/*.png
-
.github/workflows/website.ymlROADMAP.mdfrontend/test/workflow.test.mjslogs/.d4add09e83cef3872faf6ff0dd90aa7b611e2105-audit.jsonstart.shvisual-schedule-manager-portfolio/.gitignorevisual-schedule-manager-portfolio/README.mdvisual-schedule-manager-portfolio/components/schedules/AutoScheduleDialog.tsxvisual-schedule-manager-portfolio/components/schedules/BusinessHoursModal.tsxvisual-schedule-manager-portfolio/components/schedules/BusinessHoursOverlay.tsxvisual-schedule-manager-portfolio/components/schedules/CurrentTimeIndicator.tsxvisual-schedule-manager-portfolio/components/schedules/DragPreview.tsxvisual-schedule-manager-portfolio/components/schedules/DraggableJobBadge.tsxvisual-schedule-manager-portfolio/components/schedules/DroppableTimeSlot.tsxvisual-schedule-manager-portfolio/components/schedules/README.mdvisual-schedule-manager-portfolio/components/schedules/ScheduleDetailsModal.tsxvisual-schedule-manager-portfolio/components/schedules/SchedulerErrorBoundary.tsxvisual-schedule-manager-portfolio/components/schedules/TimelineGrid.tsxvisual-schedule-manager-portfolio/components/schedules/TimelineScheduler.tsxvisual-schedule-manager-portfolio/components/schedules/TimelineTrack.tsxvisual-schedule-manager-portfolio/components/schedules/TimezoneSelector.tsxvisual-schedule-manager-portfolio/components/schedules/index.tsvisual-schedule-manager-portfolio/components/ui/alert.tsxvisual-schedule-manager-portfolio/components/ui/badge.tsxvisual-schedule-manager-portfolio/components/ui/button.tsxvisual-schedule-manager-portfolio/components/ui/card.tsxvisual-schedule-manager-portfolio/components/ui/dialog.tsxvisual-schedule-manager-portfolio/components/ui/label.tsxvisual-schedule-manager-portfolio/components/ui/scroll-area.tsxvisual-schedule-manager-portfolio/components/ui/select.tsxvisual-schedule-manager-portfolio/components/ui/separator.tsxvisual-schedule-manager-portfolio/components/ui/switch.tsxvisual-schedule-manager-portfolio/components/ui/tooltip.tsxvisual-schedule-manager-portfolio/demo.tsxvisual-schedule-manager-portfolio/hooks/useDragAndDrop.tsvisual-schedule-manager-portfolio/hooks/useScheduleTimezone.tsvisual-schedule-manager-portfolio/lib/api/client.tsvisual-schedule-manager-portfolio/lib/utils.tsvisual-schedule-manager-portfolio/package.jsonvisual-schedule-manager-portfolio/stores/schedule-store.tsvisual-schedule-manager-portfolio/tailwind.config.jsvisual-schedule-manager-portfolio/tsconfig.jsonvisual-schedule-manager-portfolio/utils/auto-schedule.tsvisual-schedule-manager-portfolio/utils/collision-detection.tsvisual-schedule-manager-portfolio/utils/date.tsvisual-schedule-manager-portfolio/utils/timeline-helpers.tsvisual-schedule-manager-portfolio/utils/timezone-conversion.ts
-
- logs/.d4add09e83cef3872faf6ff0dd90aa7b611e2105-audit.json
- visual-schedule-manager-portfolio/package.json
- visual-schedule-manager-portfolio/demo.tsx
- visual-schedule-manager-portfolio/tailwind.config.js
- visual-schedule-manager-portfolio/components/ui/separator.tsx
- visual-schedule-manager-portfolio/tsconfig.json
- visual-schedule-manager-portfolio/.gitignore
- visual-schedule-manager-portfolio/components/schedules/README.md
- visual-schedule-manager-portfolio/components/ui/tooltip.tsx
- visual-schedule-manager-portfolio/components/schedules/DroppableTimeSlot.tsx
- visual-schedule-manager-portfolio/components/schedules/DraggableJobBadge.tsx
- visual-schedule-manager-portfolio/components/ui/select.tsx
- visual-schedule-manager-portfolio/components/schedules/index.ts
- visual-schedule-manager-portfolio/components/schedules/BusinessHoursOverlay.tsx
- visual-schedule-manager-portfolio/components/ui/button.tsx
- visual-schedule-manager-portfolio/components/schedules/TimezoneSelector.tsx
- visual-schedule-manager-portfolio/hooks/useScheduleTimezone.ts
- visual-schedule-manager-portfolio/components/schedules/TimelineScheduler.tsx
- visual-schedule-manager-portfolio/components/schedules/BusinessHoursModal.tsx
- start.sh
- visual-schedule-manager-portfolio/components/ui/scroll-area.tsx
- visual-schedule-manager-portfolio/components/schedules/AutoScheduleDialog.tsx
- visual-schedule-manager-portfolio/components/schedules/TimelineGrid.tsx
- visual-schedule-manager-portfolio/components/schedules/CurrentTimeIndicator.tsx
- visual-schedule-manager-portfolio/lib/utils.ts
- visual-schedule-manager-portfolio/lib/api/client.ts
- visual-schedule-manager-portfolio/components/schedules/ScheduleDetailsModal.tsx
- visual-schedule-manager-portfolio/components/schedules/SchedulerErrorBoundary.tsx
- visual-schedule-manager-portfolio/components/ui/alert.tsx
- visual-schedule-manager-portfolio/components/ui/switch.tsx
- visual-schedule-manager-portfolio/stores/schedule-store.ts
- visual-schedule-manager-portfolio/components/schedules/TimelineTrack.tsx
- visual-schedule-manager-portfolio/README.md
- visual-schedule-manager-portfolio/components/ui/badge.tsx
- visual-schedule-manager-portfolio/components/ui/dialog.tsx
- visual-schedule-manager-portfolio/hooks/useDragAndDrop.ts
- visual-schedule-manager-portfolio/components/ui/card.tsx
- visual-schedule-manager-portfolio/components/ui/label.tsx
- visual-schedule-manager-portfolio/components/schedules/DragPreview.tsx
- visual-schedule-manager-portfolio/utils/date.ts
- visual-schedule-manager-portfolio/utils/timezone-conversion.ts
- visual-schedule-manager-portfolio/utils/collision-detection.ts
- visual-schedule-manager-portfolio/utils/timeline-helpers.ts
- visual-schedule-manager-portfolio/utils/auto-schedule.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
-
scttbnsn
added a commit
that referenced
this pull request
Oct 25, 2026
) Publishes #72 (Next 16.4.3, dompurify 3.4.17, sharp 0.35.5; clears the 20 open Dependabot alerts) and #73 (verify hardening, stray-file removal, roadmap refresh). The dev tree matched the reviewed #73 head exactly; verify passed on the dev push for e422e9a and this PR's own run was skipped as the internal-promotion duplicate. Both source PRs had CodeRabbit passes with no actionable comments; CodeRabbit was rate limited on this promotion, as on #70.
scttbnsn
added a commit
that referenced
this pull request
Oct 26, 2026
- test(analytics): resolve posthog-core by package specifier and fail clearly if an upgrade drops PostHog#_runBeforeSend - test(analytics): replace the stale body check in the production browser contract; require real Flight scripts before excluding them - docs(deploy): run the browser contract after each promotion - docs(roadmap): record the #72 and #73 promotion to production Two CodeRabbit passes: one finding on the first (Flight-script filter too loose), fixed in 2801dc4; none on the second. verify and Vercel green on 2801dc4. Browser contract 1/1 against https://codeswhat.com.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch of three small concerns, each its own commit, squash on merge.
CI (the four ci(website) commits):
Repo cleanup (refactor(repo)):
Roadmap (docs(roadmap)):
Local verification on this head after rebasing onto dev at ccf6b86: actionlint clean, Biome, tsc, workflow 8/8, scene 12/12, PostHog 30/30, support 9/9, npm audit --omit=dev clean.
Summary by CodeRabbit