Skip to content

chore(release): sync release-sign fix to main - #466

Merged
scttbnsn merged 3 commits into
mainfrom
release/sync-release-sign
Oct 23, 2026
Merged

scttbnsn merged 3 commits into
mainfrom
release/sync-release-sign

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Brings #465 (release-sign download step) to main so the signing workflow can sign v0.6.0 and backfill earlier releases. Tree equals dev/v0.6.0.

Summary by CodeRabbit

  • Chores
    • Updated the release workflow to download release assets while excluding top-level signature metadata files from its downloaded set. This is an internal release-process change and does not alter the app’s features or behavior.

@biggest-littlest biggest-littlest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: release-sign fix sync.

@ALARGECOMPANY ALARGECOMPANY left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: release-sign fix sync.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7225d063-3d3d-448a-bc12-80667694f089
📥 Commits

Reviewing files that changed from the base of the PR and between 2fe5896 and 280ee1f.

📒 Files selected for processing: 1
  • .github/workflows/release-sign.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The release-signing workflow now downloads all release assets, then deletes top-level regular files matching *.sigstore.json from the download directory.

Changes: Release asset signing

Layer / File(s) Summary
Download and clean release assets
.github/workflows/release-sign.yml
The workflow downloads assets without the --exclude option. It then deletes matching top-level regular files from the download directory.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: dstahl11, biggest-littlest

Merge Risk: ⚪ Minimal · up to 280ee

The cleanup matches the documented release-signing contract and presents no merge-blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the change and expected result, but it does not use the required sections or provide Verification and Security and data details. Add the required sections: Change, Verification, and Security and data. Include the checks that were run, any missing hosted or physical acceptance, and applicable permission, retained-data, network-access, dependency, or release-authority …
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies a release-signing fix being synchronized to the main branch. It matches the primary change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Resolution

Add the required sections: Change, Verification, and Security and data. Include the checks that were run, any missing hosted or physical acceptance, and applicable permission, retained-data, network-access, dependency, or release-authority changes.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@scttbnsn
scttbnsn merged commit 4c8c8fe into main Oct 23, 2026
15 of 16 checks passed
@scttbnsn
scttbnsn deleted the release/sync-release-sign branch October 23, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants