[zombieli]

An empty match_params dictionary bypasses the URL validation because the checks use truthiness. With no URL or with a regex URL, those parameters are then silently ignored.

Check whether match_params was supplied (is not None) so empty and non-empty dictionaries follow the same validation. Extend both invalid-configuration tests and verify that a concrete URL with {} still matches only requests without query parameters. Add an Unreleased changelog entry.

Validation on Windows / Python 3.13.1:

• The two empty-dictionary rejection cases fail on the upstream implementation; the existing non-empty cases and valid empty-query control pass.
• pytest -q --cov-report=term-missing in a dedicated editable-install environment: 349 passed, 100% coverage.
• Black, Ruff, flake8 and mypy with the repository hook's isolated dependencies/arguments pass.

Prepared with OpenAI Codex assistance.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (39ccbe0) to head (20827c6).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop      #252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          366       368    +2     
  Branches        69        70    +1     
=========================================
+ Hits           366       368    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[Colin-b]

I am not sure about this, why would you even provide it as empty? The default behavior is to check the full URL with params included. So it covers it. The regex case look valid but again, this is user provided regex, so they should include the query parameters as well if this is what they want to assert

[zombieli]

You're right that normal URL matching already checks the query parameters. My intent here was only to make configuration validation consistent: with no URL or a regex URL, match_params={} is currently ignored, while a non-empty dict raises.

I found this through code inspection rather than a real-world failing use case. Since this would make previously accepted configurations raise, consistency alone may not justify the change. Would you prefer to keep ignoring an empty dict in these cases?

[Colin-b]

You are right, this might be misleading to some people, even if this is an edge case. Better be safe than sorry, I'm fine with the change

[Colin-b]

Few comments and we also lack the same changes on the async test file

[Colin-b]

Suggested change

	- Empty `match_params` now requires a non-regex URL, just like non-empty `match_params`.
	- Providing an empty `match_params` will now assert that no query parameters was provided. Note that you do not need to provide it if you already use the `url` parameter and this value does not contains query parameters.

[zombieli]

Updated the changelog to describe the empty-query assertion, including when url is omitted, and to note that a concrete URL without query parameters already provides this behavior.

[Colin-b]

Suggested change

	httpx_mock.add_response(url="https://test_url", match_params={}, is_reusable=True)
	httpx_mock.add_response(match_params={}, is_reusable=True)

[Colin-b]

With this change we actually test a more realistic use case of empty match_params

[zombieli]

Updated the test to omit url and added matching async coverage. I also adjusted the matcher so match_params={} is accepted without a URL and only matches requests without query parameters. The tests cover different URLs, query mismatches, the default None behavior, and invalid configurations. Non-empty match_params still requires a URL; combining match_params with a regex URL remains unsupported.

Local validation on Windows / Python 3.13.1: 359 tests passed with 100% coverage. Formatting, lint/type checks, the remaining configured hooks, and sdist/wheel builds also passed.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud