Repository navigation
Fix missing symbol - #1075
Closed
purplegrape wants to merge 5 commits into
Closed
Fix missing symbol#1075purplegrape wants to merge 5 commits into
purplegrape wants to merge 5 commits into
Conversation
purplegrape
force-pushed
the
fix-missing-symbol
branch
from
October 12, 2026 13:49
64212bf to
67c9f8e
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The 50 unrelated license-header edits should be reverted, split out, or documented as part of the intended scope.
1 open finding
What changed in this PR
Fixes malformed positional placeholders in localized date-range labels and updates license URLs.
Changes:
- Restores
%1$sin nine UI dictionaries. - Changes AGPL links from HTTP to HTTPS across 50 dictionary files.
| File | Description |
|---|---|
dictionaries/zh_cn.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/ui/pages/login/en.dictionary.itop.login.php |
Updates license URL. |
dictionaries/ui/layouts/ui-content-block/en.dictionary.itop.ui-content-block.php |
Updates license URL. |
dictionaries/ui/layouts/tab-container/en.dictionary.itop.tab-container.php |
Updates license URL. |
dictionaries/ui/layouts/page-content/en.dictionary.itop.page-content.php |
Updates license URL. |
dictionaries/ui/layouts/object-details/en.dictionary.itop.object-details.php |
Updates license URL. |
dictionaries/ui/application/welcome-popup/en.dictionary.itop.welcome-popup.php |
Updates license URL. |
dictionaries/ru.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/pt_br.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/pl.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/nl.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/hu.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/fr.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/es_cr.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/en.dictionary.itop.ui.php |
Updates license URL. |
dictionaries/en.dictionary.itop.core.php |
Updates license URL. |
dictionaries/cs.dictionary.itop.ui.php |
Fixes placeholder. |
dictionaries/core/uniqueness-rule/en.dictionary.itop.uniqueness-rule.php |
Updates license URL. |
dictionaries/core/orm-value/orm-document/en.dictionary.itop.orm-document.php |
Updates license URL. |
datamodels/2.x/itop-welcome-itil/dictionaries/en.dict.itop-welcome-itil.php |
Updates license URL. |
datamodels/2.x/itop-virtualization-mgmt/dictionaries/en.dict.itop-virtualization-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-tickets/dictionaries/en.dict.itop-tickets.php |
Updates license URL. |
datamodels/2.x/itop-themes-compat/dictionaries/en.dict.itop-themes-compat.php |
Updates license URL. |
datamodels/2.x/itop-structure/dictionaries/en.dict.itop-structure.php |
Updates license URL. |
datamodels/2.x/itop-storage-mgmt/dictionaries/en.dict.itop-storage-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-service-mgmt/dictionaries/en.dict.itop-service-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-service-mgmt-provider/dictionaries/en.dict.itop-service-mgmt-provider.php |
Updates license URL. |
datamodels/2.x/itop-request-mgmt/dictionaries/en.dict.itop-request-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-request-mgmt-itil/dictionaries/en.dict.itop-request-mgmt-itil.php |
Updates license URL. |
datamodels/2.x/itop-problem-mgmt/dictionaries/en.dict.itop-problem-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-portal/dictionaries/en.dict.itop-portal.php |
Updates license URL. |
datamodels/2.x/itop-oauth-client/dictionaries/en.dict.itop-oauth-client.php |
Updates license URL. |
datamodels/2.x/itop-knownerror-mgmt/dictionaries/en.dict.itop-knownerror-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-incident-mgmt-itil/dictionaries/en.dict.itop-incident-mgmt-itil.php |
Updates license URL. |
datamodels/2.x/itop-hub-connector/dictionaries/en.dict.itop-hub-connector.php |
Updates license URL. |
datamodels/2.x/itop-flow-map/dictionaries/en.dict.itop-flow-map.php |
Updates license URL. |
datamodels/2.x/itop-files-information/dictionaries/en.dict.itop-files-information.php |
Updates license URL. |
datamodels/2.x/itop-faq-light/dictionaries/en.dict.itop-faq-light.php |
Updates license URL. |
datamodels/2.x/itop-endusers-devices/dictionaries/en.dict.itop-endusers-devices.php |
Updates license URL. |
datamodels/2.x/itop-datacenter-mgmt/dictionaries/en.dict.itop-datacenter-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-core-update/dictionaries/en.dict.itop-core-update.php |
Updates license URL. |
datamodels/2.x/itop-container-mgmt/dictionaries/en.dict.itop-container-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-config/dictionaries/en.dict.itop-config.php |
Updates license URL. |
datamodels/2.x/itop-config-mgmt/dictionaries/en.dict.itop-config-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-change-mgmt/dictionaries/en.dict.itop-change-mgmt.php |
Updates license URL. |
datamodels/2.x/itop-change-mgmt-itil/dictionaries/en.dict.itop-change-mgmt-itil.php |
Updates license URL. |
datamodels/2.x/itop-bridge-cmdb-ticket/dictionaries/en.dict.itop-bridge-cmdb-ticket.php |
Updates license URL. |
datamodels/2.x/itop-bridge-cmdb-services/dictionaries/en.dict.itop-bridge-cmdb-services.php |
Updates license URL. |
datamodels/2.x/itop-backup/dictionaries/en.dict.itop-backup.php |
Updates license URL. |
datamodels/2.x/combodo-db-tools/dictionaries/en.dict.combodo-db-tools.php |
Updates license URL. |
datamodels/2.x/combodo-data-feature-removal/dictionaries/en.dict.combodo-data-feature-removal.php |
Updates license URL. |
datamodels/2.x/combodo-backoffice-fullmoon-tritanopia-theme/dictionaries/en.dict.combodo-backoffice-fullmoon-tritanopia-theme.php |
Updates license URL. |
datamodels/2.x/combodo-backoffice-fullmoon-protanopia-deuteranopia-theme/dictionaries/en.dict.combodo-backoffice-fullmoon-protanopia-deuteranopia-theme.php |
Updates license URL. |
datamodels/2.x/combodo-backoffice-fullmoon-high-contrast-theme/dictionaries/en.dict.combodo-backoffice-fullmoon-high-contrast-theme.php |
Updates license URL. |
datamodels/2.x/combodo-backoffice-darkmoon-theme/dictionaries/en.dict.combodo-backoffice-darkmoon-theme.php |
Updates license URL. |
datamodels/2.x/authent-local/dictionaries/en.dict.authent-local.php |
Updates license URL. |
datamodels/2.x/authent-ldap/dictionaries/en.dict.authent-ldap.php |
Updates license URL. |
datamodels/2.x/authent-external/dictionaries/en.dict.authent-external.php |
Updates license URL. |
datamodels/2.x/authent-cas/dictionaries/en.dict.authent-cas.php |
Updates license URL. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| /* | ||
| * @copyright Copyright (C) 2010-2026 Combodo SAS | ||
| * @license http://opensource.org/licenses/AGPL-3.0 | ||
| * @license https://opensource.org/licenses/AGPL-3.0 |
…egrape/iTop into fix-missing-symbol" This reverts commit 989d176, reversing changes made to 06b628b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing symbol.
old branches also have the same issue.