Skip to content

N°10202 - CEX: Inline image as URL unreadable due to security fix - #1079

Merged
accognet merged 5 commits into
support/3.2.3from
issue/10202-inline_image
Oct 16, 2026
Merged

accognet merged 5 commits into
support/3.2.3from
issue/10202-inline_image

Conversation

@accognet

Copy link
Copy Markdown
Contributor

internal

Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:18
@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Oct 15, 2026
@accognet
accognet changed the base branch from develop to support/3.2.3 October 15, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Authentication remains enabled by default, and the only retained finding is a nonblocking wording correction.

1 open finding
What changed in this PR

Adds an opt-in setting to support inline-image access from third-party integrations without login.

Changes:

  • Adds a configuration flag, disabled by default.
  • Skips inline-image login enforcement when the flag is enabled.
File Description
pages/​ajax.document.php Makes inline-image login conditional on configuration.
core/​config.class.inc.php Defines the option and documents unauthenticated access.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread core/config.class.inc.php Outdated
@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The PR appears safe to merge; anonymous image access is opt-in and still requires a matching image secret.

Summary

Adds security.disable_inline_images_protection so third-party tools can display inline images without logging in.

  • Inline-image URLs can skip login when protection is disabled.

Reviews (1) · Last reviewed commit: "N°10202 - Third-party tool interface; in..." · Reviewed by Greptile

@Molkobain
Molkobain requested review from jf-cbd and steffunky October 15, 2026 15:18

@Molkobain Molkobain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a dedicated security flag for these specific use cases seems like a good idea, well done.

Just some remark about naming and convention.

Comment thread core/config.class.inc.php Outdated
Comment thread pages/ajax.document.php Outdated
@Molkobain
Molkobain requested a review from rquetiez October 15, 2026 15:29

@rquetiez rquetiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view, the security remains correct when fetching the images require authentication : the secret acts as a bearer token and protects against malicious access to all database images.

Comment thread core/config.class.inc.php Outdated
accognet and others added 3 commits October 16, 2026 11:46
Co-authored-by: Molkobain <lajarige.guillaume@free.fr>
Co-authored-by: Molkobain <lajarige.guillaume@free.fr>
Comment thread core/config.class.inc.php Outdated
Co-authored-by: Molkobain <lajarige.guillaume@free.fr>

@Molkobain Molkobain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@Molkobain Molkobain changed the title N°10202 - Third-party tool interface; inline image unreadable due to integration issues N°10202 - CEX: Inline image as URL unreadable due to secuirty fix Oct 16, 2026
@Molkobain Molkobain added this to the 3.2.3-3 milestone Oct 16, 2026
@accognet
accognet merged commit 692c072 into support/3.2.3 Oct 16, 2026
@accognet
accognet deleted the issue/10202-inline_image branch October 16, 2026 11:29
@Molkobain Molkobain changed the title N°10202 - CEX: Inline image as URL unreadable due to secuirty fix N°10202 - CEX: Inline image as URL unreadable due to security fix Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants