Repository navigation
N°10202 - CEX: Inline image as URL unreadable due to security fix - #1079
Conversation
…integration issues
There was a problem hiding this comment.
🟢 Approval recommended
Authentication remains enabled by default, and the only retained finding is a nonblocking wording correction.
1 open finding
What changed in this PR
Adds an opt-in setting to support inline-image access from third-party integrations without login.
Changes:
- Adds a configuration flag, disabled by default.
- Skips inline-image login enforcement when the flag is enabled.
| File | Description |
|---|---|
| pages/ajax.document.php | Makes inline-image login conditional on configuration. |
| core/config.class.inc.php | Defines the option and documents unauthenticated access. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
[Critical impact] The PR appears safe to merge; anonymous image access is opt-in and still requires a matching image secret.
|
Molkobain
left a comment
There was a problem hiding this comment.
Using a dedicated security flag for these specific use cases seems like a good idea, well done.
Just some remark about naming and convention.
rquetiez
left a comment
There was a problem hiding this comment.
From my point of view, the security remains correct when fetching the images require authentication : the secret acts as a bearer token and protects against malicious access to all database images.
Co-authored-by: Molkobain <lajarige.guillaume@free.fr>
Co-authored-by: Molkobain <lajarige.guillaume@free.fr>
…integration issues - change comment
Co-authored-by: Molkobain <lajarige.guillaume@free.fr>

internal