Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 2293Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 2293" |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line deletion matches the stated scope, preserves explicit package routing, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR narrows NuGet source routing to avoid unnecessary lookups against the dotnet9-transport feed.
Changes:
- Removes the transport feed’s wildcard package mapping.
- Preserves the explicit
Microsoft.DotNet.GenAPI.Taskmapping and leaves all other configuration unchanged.
| File | Description |
|---|---|
nuget.config |
Restricts the transport feed to its explicitly mapped build-tool package. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: None supplied; prior issue approval has not been verified.
Remove only
<package pattern="*" />from thedotnet9-transportpackage source mapping in rootnuget.config. Keep its explicitMicrosoft.DotNet.GenAPI.Taskmapping and all other configuration unchanged.PR Checklist
Other information
The investigated Dependabot job ran for 55 minutes before cancellation, expanded 279 projects, performed 494 restores, and logged 4,443 HTTP 404 responses from the transport feed, many cached. Removing the wildcard avoids unnecessary transport-feed lookups for packages without a more specific mapping. It does not address repeated solution-wide analysis, and no runtime improvement has been measured.
Created in a clean isolated worktree after fetching upstream
main; the base wasf89a8f8bfe91ae70ce0e7726d97b89ee86e03825. No registry-access changes or unrelated parent-worktree changes are included.Validation:
git diff --check— passed before committing.[xml]$config = Get-Content .\nuget.config -Raw— passed: valid XML.Microsoft.DotNet.GenAPI.Task, and the complete configuration matchesorigin/main:nuget.configexcept for the requested wildcard deletion.