Repository navigation
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 2295Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 2295" |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently preserve the existing .NET 10 configuration with no blocking issues identified in static review, though builds and tests were not run.
No open issues 🎉
What changed in this PR
This PR makes the toolkit .NET 10-only for the next release, removing older framework support and reducing Dependabot’s framework evaluation work.
Changes:
- Remove .NET 8 and .NET 9 targets and obsolete SQLite and KurrentDB dependency conditions.
- Simplify CI SDK installation to .NET 10 only.
- Update prerequisites and clarify an Entity Framework comment without changing its implementation.
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.KurrentDB.Tests/CommunityToolkit.Aspire.KurrentDB.Tests.csproj | Remove the older-framework async LINQ dependency. |
| src/Shared/EntityFrameworkUtils.cs | Update the EF Core compatibility comment only. |
| src/CommunityToolkit.Aspire.Microsoft.EntityFrameworkCore.Sqlite/CommunityToolkit.Aspire.Microsoft.EntityFrameworkCore.Sqlite.csproj | Retain only .NET 10 dependencies. |
| src/CommunityToolkit.Aspire.Microsoft.Data.Sqlite/CommunityToolkit.Aspire.Microsoft.Data.Sqlite.csproj | Retain only the .NET 10 SQLite dependency. |
| src/CommunityToolkit.Aspire.KurrentDB/CommunityToolkit.Aspire.KurrentDB.csproj | Remove the older-framework async LINQ dependency. |
| src/CommunityToolkit.Aspire.Hosting.KurrentDB/CommunityToolkit.Aspire.Hosting.KurrentDB.csproj | Remove the older-framework async LINQ dependency. |
| src/CommunityToolkit.Aspire.Hosting.Flyway/README.md | Raise the prerequisite to .NET 10. |
| src/CommunityToolkit.Aspire.Hosting.Flagd/README.md | Raise the prerequisite to .NET 10. |
| examples/python/streamlit-api/README.md | Document the .NET 10 prerequisite. |
| docs/setup.md | Require only .NET 10 for development. |
| Directory.Build.props | Limit shared target frameworks to .NET 10. |
| .github/workflows/package.yml | Install only the .NET 10 SDK. |
| .github/workflows/generate-api-diffs.yml | Install only the .NET 10 SDK. |
| .github/workflows/copilot-setup-steps.yml | Install only the .NET 10 SDK. |
| .github/workflows/codeql.yml | Install only the .NET 10 SDK. |
| .github/actions/setup-runtimes-caching/action.yml | Limit shared SDK setup to .NET 10. |
Review effort: Balanced
3 of 10 tasks
Contributor
Author
|
@aaronpowell any concerns about dropping net8/9 support? Change has been made upstream in microsoft/aspire#20614 . But dropping support could be a problem if we do a CT release before aspire 17. |
Member
|
Yes, but we'll want to wait until the next major of Aspire where they drop so we keep alignment. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
net8.0andnet9.0support ahead of the next release, which will happen after .NET 8 and .NET 9 go out of support in November.Changes
net10.0only and remove obsolete framework-specific SQLite and KurrentDB dependency conditions.Validation
git diff --checkpassed.