Repository navigation
Increase Ollama TypeScript health wait timeout - #2297
Merged
Merged
Conversation
Allow ten minutes for Ollama image pulls before resource readiness times out. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 2297Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 2297" |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped change uses the existing timeout mechanism without weakening health checks or affecting other tests.
No open issues 🎉
What changed in this PR
Increases the Ollama TypeScript AppHost test’s health-wait timeout to accommodate slow cold Docker image pulls.
Changes:
- Sets a 600-second timeout for
ollamaandollama2, up from the shared 180-second default. - Preserves health requirements and leaves the shared default and DbGate tests unchanged.
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.Ollama.Tests/TypeScriptAppHostTests.cs | Adds the Ollama-specific 600-second timeout override. |
Review effort: Balanced
Contributor
|
afscrome
enabled auto-merge (squash)
October 24, 2026 21:44
aaronpowell
approved these changes
Oct 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increase the Ollama TypeScript AppHost test's resource health wait from 180 to 600 seconds. This is scoped to
ollamaandollama2; the shared default and DbGate tests are unchanged.In the failing CI job, the health wait expired while Docker was still pulling
ollama/ollama:0.34.4. The concurrent C# test's image pull took approximately 4 minutes 13 seconds, after which Ollama started successfully. The extra time accommodates slow cold image pulls without weakening the health requirement.Validation
dotnet build tests\CommunityToolkit.Aspire.Hosting.Ollama.Tests\CommunityToolkit.Aspire.Hosting.Ollama.Tests.csproj --verbosity quiet— passed with zero warnings and zero errors.git diff --check— passed.