CXP-383 Support audit log pagination for both GHEC and GHES

[JavierCarnelli-ConductorOne]

The pagination token on GHEC and GHES is different for each. So this PR adds support to both of them

[linear-code]

CXP-383

[github-actions]

🟡 Suggestion: The new GHES numeric-page branch has no test coverage. TestUsageEventFeed_ListEvents_ContinuesPastAnAllFilteredPage only exercises the GHEC path (Link: <...?page=cursor2>; rel="next"), so the resp.NextPage fallback this PR adds would still pass if it regressed. Consider adding a sibling test whose mocked handler emits a numeric Link: <...?page=2>; rel="next" header and asserting the second request is issued with page=2. (confidence: high)

[github-actions]

Connector PR Review: CXP-383 Support audit log pagination for both GHEC and GHES

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 6db6df6744de.
Review mode: full
View review run

Review Summary

Scanned the full PR diff (one file, pkg/connector/usage_event_feed.go) for security and correctness. The change extracts the audit-log next-page decision into nextAuditLogPage, preserving the existing GHEC opaque-cursor behavior via Response.NextPageToken and adding a GHES fallback to the numeric Response.NextPage, which matches the repo's existing fmtGitHubPageToken convention in helpers.go. The helper is only reached under the resp != nil guard at pkg/connector/usage_event_feed.go:206, strconv was already imported, Organizations.GetAuditLog has no other call site that needs the same fix, and go.mod/go.sum are unchanged — no security or correctness issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

• pkg/connector/usage_event_feed.go:249 — the new GHES numeric-page branch is untested; existing pagination coverage only exercises the non-numeric GHEC cursor.

Prompt for AI agents

Verify each finding against the current code and only fix it if needed.

## Suggestions

In `pkg/connector/usage_event_feed.go`:
- Around line 249 (`nextAuditLogPage`): the GHES numeric-page fallback that reads
  `resp.NextPage` has no test. The existing test
  `TestUsageEventFeed_ListEvents_ContinuesPastAnAllFilteredPage` in
  `pkg/connector/usage_event_feed_test.go` only emits a non-numeric GHEC cursor
  Link header (`<https://api.github.com/orgs/octo-org/audit-log?page=cursor2>; rel="next"`),
  so it exercises only the `NextPageToken` branch. Add a sibling table or test —
  e.g. `TestUsageEventFeed_ListEvents_PaginatesNumericGHESPages` — that uses
  `mock.WithRequestMatchHandler(mock.GetOrgsAuditLogByOrg, ...)` and sets a numeric
  Link header (`<https://ghes.example.com/api/v3/orgs/octo-org/audit-log?page=2&per_page=100>; rel="next"`)
  on the first response and no Link header on the second. Assert that two requests
  were made, that the second request carries the `page=2` query parameter, and that
  events from both pages are returned. Optionally also add a direct unit test for
  `nextAuditLogPage` covering the three cases: NextPageToken set, NextPage set, and
  neither set (expect "").

[github-actions]

No blocking issues found.