Skip to content

ci: install the baton CLI from baton-sdk releases - #41

Merged
jugonzalez12 merged 1 commit into
mainfrom
jugonzalez/get-baton-from-sdk
Sep 15, 2026
Merged

jugonzalez12 merged 1 commit into
mainfrom
jugonzalez/get-baton-from-sdk

Conversation

@jugonzalez12

Copy link
Copy Markdown
Contributor

The archived conductorone/baton CLI cannot open c1z files written by baton-sdk v0.30.0 and newer, so the CI job that installed it fails at the first baton command once this repo's SDK moves. This installs the CLI shipped with baton-sdk releases through the shared get-baton action instead, as the sibling connector repos already do, and removes the repo-local install script where nothing else referenced it.

Opened as a draft to run CI; any remaining red here is a separate, pre-existing failure the old CLI error was masking.

🤖 Generated with Claude Code

The archived conductorone/baton CLI cannot open c1z files written by
baton-sdk v0.30.0 and newer, so the job that installed it fails at the
first baton command once this repo's SDK moves. Install the CLI shipped
with baton-sdk releases through the shared get-baton action instead, as
the sibling connector repos already do.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: ci: install the baton CLI from baton-sdk releases

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base cebdf2d20720.
Review mode: full
View review run

Review Summary

Scanned the full PR diff for security and correctness: it swaps the Install baton step in .github/workflows/ci.yaml from the repo-local scripts/get-baton.sh to the shared ConductorOne/github-workflows/actions/get-baton@v4 action, and deletes the now-unused script. Verified that the action at v4 installs the binary to /usr/local/bin/baton, so the later bare baton grants invocations still resolve; that the latest baton-sdk release (v0.30.0) ships the baton-v0.30.0-linux-amd64.tar.gz asset the action matcher expects; and that no Makefile, workflow, or doc still references scripts/get-baton.sh. No Go, go.mod, or go.sum changes are in this PR, and the test job already passed on this head SHA using the new CLI.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@jugonzalez12
jugonzalez12 marked this pull request as ready for review September 14, 2026 23:45
@jugonzalez12
jugonzalez12 merged commit c94166d into main Sep 15, 2026
8 checks passed
@jugonzalez12
jugonzalez12 deleted the jugonzalez/get-baton-from-sdk branch September 15, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants