Pin dtolnay/rust-toolchain to a master commit - #703
Merged
Merged
Conversation
The pinned commit came from the action's `stable` branch, which upstream regenerates. On 2026-10-01 it was rewritten and the old commit left every branch and tag, so zizmor reports it as an impostor commit and CI fails on every PR. The pin now names a commit on `master`, which is not rewritten; the workflows already pass `toolchain: stable`. The only runtime change since the old pin is a retry when rustup hits a checksum failure during an upstream release update.
davidmckayv
requested review from
MikeRyanDev,
guidovizoso,
mxmzb and
tylerslaton
as code owners
October 2, 2026 00:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Static analysis (zizmor)fails on every PR since 2026-10-01 withimpostor-commiton the threedtolnay/rust-toolchainpins indesktop.ymlanddesktop-signing.yml. The pinned commit (6bed076, 2026-09-03) came from the action'sstablebranch, which upstream regenerates; it was rewritten today and the old commit is no longer on any branch or tag (compare stable...6bed076: diverged).This repins to
7e38f4bonmaster, which is not rewritten. The workflows already passtoolchain: stable, whichmasterrequires. The only runtime change between the two commits (action.yml) is a retry loop whenrustup toolchain installhits a checksum failure during an upstream release update, plus--force-non-host; read in full before pinning.Where it runs
Boundary and audit
Changelog
Proof
zizmor --gh-token ... .github/workflows/desktop.yml .github/workflows/desktop-signing.yml(online, as CI runs it):mainreports 2 highimpostor-commiterrors; this branch reports no findings.