fix: preserve reverted drafts after save errors - #44
Open
Bortlesboat wants to merge 1 commit into
Open
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
Keep a reverted draft when polling observes a save whose response was lost. The existing conflict flow lets the user decide whether to load the remote page. Cover the lost-response sequence and explicit load-latest recovery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the user's reverted page draft when the server commits an autosave but its response is lost. In the page editor, start with
Original, edit toTemporary, revert toOriginalwhile the save is pending, then lose the response: the next poll currently replaces the draft withTemporaryand marks it saved. The draft now stays in the existing conflict flow until the user resolves it.The regression fails before the fix and passes afterward, including explicit “Load latest” recovery. On Node 24.14.0, all 165 tests, typecheck, lint, formatting and the production build pass; validation used the autosave controller and existing component tests, without an interactive browser walkthrough.