Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat run aborts browser/search work when the user stops it, but creates its computer tools without that run's abort signal. An active
run_computer_commandtherefore keeps executing until its own timeout, while the chat UI has already stopped.Pass the chat run's abort signal and a pre-dispatch guard to the computer tool wrapper. The existing computer executor handles an interrupted command and records its uncertain outcome.
The mock-model regression starts a computer command, unsubscribes the run, and asserts the command receives the aborted signal. Before the change it receives no signal. Verification: 21 related tests passed; TypeScript and changed-file Biome checks passed.