Skip to content

fix(build): save assets and scenes before BuildPlayer #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TeapoyY wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

fix(build): save assets and scenes before BuildPlayer #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions MCPForUnity/Editor/Tools/Build/BuildRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using UnityEditor;
using UnityEditor.Build.Reporting;
using UnityEditor.Build;
using UnityEditor.SceneManagement;
using MCPForUnity.Editor.Helpers;

namespace MCPForUnity.Editor.Tools.Build
Expand Down Expand Up @@ -110,6 +111,7 @@ private static void RunBuildCore(BuildJob job, Func<BuildReport> buildFunc)

try
{
SaveBeforeBuild();
BuildReport report = buildFunc();
job.CompletedAt = DateTime.UtcNow;

Expand Down Expand Up @@ -230,5 +232,19 @@ private static string[] GetDefaultScenes()
.Select(s => s.path)
.ToArray();
}

/// <summary>
/// Saves assets and open scenes before building so BuildPipeline does not block on a save dialog.
/// </summary>
private static void SaveBeforeBuild()
{
AssetDatabase.SaveAssets();
if (!EditorSceneManager.SaveOpenScenes())
{
McpLog.Warn(
"[MCP Build] Some modified scenes could not be saved (new scenes need a path). " +
"Build may still prompt to save.");
}
}
}
}