fix(stdio): refresh port discovery before reconnect backoff - #1345
fix(stdio): refresh port discovery before reconnect backoff#1345SeojunKim-pumisj wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe retry path now refreshes the stdio port registry before rediscovering a Unity port. An integration test verifies recovery from a stale cached port and confirms ChangesUnity port refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change refreshes port discovery before stdio reconnect retries and adds regression coverage for stale cached ports; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The implementation satisfies issue ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Refresh stdio port discovery immediately after a Unity communication failure. This lets reconnect attempts follow a new port announced in the status registry after a domain reload instead of reusing the cached port until its TTL expires.
Type of Change
Changes Made
Compatibility / Package Source
#beta,#main, tag, branch, orfile:):betaPackages/packages-lock.json(if using a Git package URL): Not applicableTesting/Screenshots/Recordings
cd Server && uv run pytest tests/ -v): 1375 passed, 3 skippedDocumentation Updates
tools/UPDATE_DOCS_PROMPT.md(recommended)Related Issues
Fixes #1339
Additional Notes
Unity tests were not run because this change only affects Python stdio reconnection and does not modify the Unity package. The regression test exercises the cache TTL scenario without requiring a Unity Editor.
Summary by CodeRabbit