Repository navigation
ui: fix dashboard freezes in live mode - #1
Merged
Merged
Conversation
Live mode moves the time range every second. On a big dashboard this made every plot redraw every second and left-menu previews block the main thread on canvas readback, so the page froze for seconds and opening a plot took 5-10 s in Firefox. - useMetricData: don't renormalize the same response on time range ticks; depend on heal status and theme instead. Drop the unused timeRange param of normalizePlotData and PlotData.lastTimeRange. - UPlotWrapper: one coalesced draw per scale update (redraw then setScale, no batch, so the y-lock reset still sees the parent ref); skip sub-pixel x shifts; reapply scales after resize. - Plot previews: replay uPlot's cached paths onto a software canvas instead of drawImage from the plot canvas, throttle to one per plot per 5 s, keep the old preview while series aren't drawn yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live mode moves the time range every second. On a big dashboard this made every plot redraw every second and left-menu previews block the main thread on canvas readback, so the page froze for seconds and opening a plot took 5-10 s in Firefox.