Fix the CI: pin third-party repositories and fix package dependencies - #58
Merged
Merged
Conversation
The rolling branch no longer exists. main targets ROS 2 Humble, so use humble-devel. The CI now reads thirdparty.repos from the checked out commit instead of the main branch, so pull requests test their own version of the file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates ROS 2 Humble dependency resolution and CI configuration.
Changes:
- Switches
cascade_lifecycletohumble-devel. - Uses the checked-out
thirdparty.reposduring CI.
| File | Summary |
|---|---|
robocup_bringup/thirdparty.repos |
Updates the dependency branch. |
.github/workflows/main.yaml |
Uses the checked-out repository configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Pin the third-party repositories to the commits that match this code (2024). Their main branches changed their APIs since then (yolo_msgs, whisper_ros STT result, perception_system, slam_toolbox CMake). - Declare in package.xml the dependencies used in CMakeLists.txt, and fix the manipulation_interfaces typo in motion, so colcon builds in order. - Fix lint_cmake and flake8 issues. - CI runs in the ROS 2 Humble image of ros-tooling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fmrico
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets the CI of
maingreen again. Checked locally in the same ROS 2 Humble image: 21 packages build and 435 tests pass.thirdparty.reposto the commits that match this code (2024). Theirmainbranches changed their APIs since then:yolo_msgsinstead ofyolov8_msgs, thewhisper_rosSTT result,perception_system, and theslam_toolboxCMake policy.cascade_lifecyclehad norollingbranch any more.CMakeLists.txt, and fix themanipultaion_interfacestypo inmotion, so colcon builds the packages in the right order.lint_cmakeinbt_testandflake8in therobocup_bringuplaunch files.thirdparty.reposfrom the checked out commit, and no longer requestscs4home_core, which is not part of this workspace.🤖 Generated with Claude Code