Skip to content

Add NAD phosphorylation and dephosphorylation pathway - #480

Merged
realmarcin merged 2 commits into
mainfrom
feat/pathway-next-232-20261012
Oct 12, 2026
Merged

realmarcin merged 2 commits into
mainfrom
feat/pathway-next-232-20261012

Conversation

@realmarcin

@realmarcin realmarcin commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Add NAD phosphorylation and dephosphorylation as a complete microbial pathway record, with 102 mechanistic edges, 97 references, generated network diagrams and KGX exports. Distinguish native pathway definitions, primary experiments and assay-specific PhoA/CysQ activity, while preserving the unknown physiological cytosolic NADP phosphatase.

Add EcoCyc protein-complex authority support with reproducible provenance serialization. The reviewed correction separates the 1987 Table 2 inhibition assays at 4.0 mM NAD from the general 10 mM assay and variable-NAD saturation experiments. Save the scientific review lineage and supported corrections, and preserve the no-bytecode environment in the history-validator regression test.

Validation: all nine maintained gates passed; 2,635 tests passed and 3 skipped. Native validation accepts all 110 review bundles. Preservation checks confirm the existing 232 records/pages, prior reviews/history, graph edges, source contexts and cached originals remain intact. Independent adversarial follow-up accepted commit 79c38b9 with no new actionable findings; GitHub qc and vendored-sync also passed for that exact commit.

Closes #465
Closes #466
Closes #467
Closes #468
Closes #469
Closes #471
Closes #472
Closes #473
Closes #483
Closes #487

@realmarcin

Copy link
Copy Markdown
Contributor Author

Independent adversarial follow-up accepted exact commit 79c38b9b8a419506155a8573c1539e50f6af4f5d (tree 08e09f0b40f00f1b19ce551cabcb10c8925782f5) with no new actionable findings.

The review verified all 202 committed changes: four modified files and 198 additions. The assay correction changes one paragraph and two ledger text pointers; the graph, endpoint qualifiers and references are unchanged. The two-file provenance fix matches the independently tested proposal. Native review 110, all 170 input hashes, 29 evidence hashes, archive scope and graph/KGX preservation were checked against committed blobs. A separate scoped scientific review passed 22 checks and visually rechecked the primary assay pages.

All nine current maintained gates passed (2,635 tests passed, 3 skipped); native validation accepts 110 review bundles. GitHub qc and vendored-sync passed for this commit. Unchanged scientific judgments and access limits inherit the earlier exact-0f5 review; this is a bounded correction follow-up.

Final review handoff SHA256: 95b9b08d6561ebbd750da2b01b6c7ce08df616690faddbf8a4d8da80aa717ac0.
Review report SHA256: f90f39af0d2a34af3be24489c9b3b642bb266e5c393dd44fa9b862bfbbba565a.

@realmarcin
realmarcin marked this pull request as ready for review October 12, 2026 12:21
@realmarcin
realmarcin added this pull request to the merge queue Oct 12, 2026
Merged via the queue into main with commit e1c6691 Oct 12, 2026
2 checks passed
@realmarcin
realmarcin deleted the feat/pathway-next-232-20261012 branch October 12, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment