Repository navigation
tests: clear persistent upload jobs before and after each GUI test - #123
Merged
paulmueller merged 1 commit intoNov 4, 2026
Merged
Conversation
Each new main window restored the unfinished upload jobs of all previous GUI tests and uploaded them again. A slow or failing leftover upload then blocked the job the test was waiting for (e.g. test_gui_upload_private on Windows). Also print the 20 slowest tests in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 72.84% 72.74% -0.10%
==========================================
Files 72 72
Lines 6057 6057
==========================================
- Hits 4412 4406 -6
- Misses 1645 1651 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the GUI tests independent of the upload jobs left over by previous tests.
Problem
Persistent upload jobs were only cleared at the start and end of the test session. Several GUI tests (
test_gui_upload_simplewithset_job_done=False,test_gui_upload_task,..._bad_dataset_id_yes,..._missing_circle_multiple) leave unfinished jobs behind, and every newDCORAid()main window restored and uploaded them again.In the failing Windows run of main (job 126698909538),
test_gui_upload_privatetimed out in stateparcel: the upload queue was busy re-uploading a leftovergorgonzola.rtdcjob from an earlier test, whose connections to the object store were refused (WinError 10061) for over a minute.Changes
tests/test_gui.py: new autouse fixture that callscleanup_dcoraid_tasks()before and after each GUI test.github/workflows/check.yml:pytest --durations=20;test_gui.pytook 22 min on Windows vs. 3 min on Linux, and this shows which tests are slowCHANGELOG: tests entryNot addressed here
test_gui_upload_task_missing_circlefailed in the same run withRemoteDisconnectedfrom dcor-dev. urllib3 counts that as a read error, and the API'sRetryusesread=0, so the GET was not retried.Testing
tests/test_gui.pypasses locally on Linux (12 passed). CI cannot run the tests for fork PRs.🤖 Generated with Claude Code