Skip to content

tests: clear persistent upload jobs before and after each GUI test - #123

Merged
paulmueller merged 1 commit into
DCOR-dev:mainfrom
paulmueller-agent:fix-gui-test-isolation
Nov 4, 2026
Merged

paulmueller merged 1 commit into
DCOR-dev:mainfrom
paulmueller-agent:fix-gui-test-isolation

Conversation

@paulmueller-agent

Copy link
Copy Markdown
Contributor

Makes the GUI tests independent of the upload jobs left over by previous tests.

Problem
Persistent upload jobs were only cleared at the start and end of the test session. Several GUI tests (test_gui_upload_simple with set_job_done=False, test_gui_upload_task, ..._bad_dataset_id_yes, ..._missing_circle_multiple) leave unfinished jobs behind, and every new DCORAid() main window restored and uploaded them again.

In the failing Windows run of main (job 126698909538), test_gui_upload_private timed out in state parcel: the upload queue was busy re-uploading a leftover gorgonzola.rtdc job from an earlier test, whose connections to the object store were refused (WinError 10061) for over a minute.

Changes

  • tests/test_gui.py: new autouse fixture that calls cleanup_dcoraid_tasks() before and after each GUI test
  • .github/workflows/check.yml: pytest --durations=20; test_gui.py took 22 min on Windows vs. 3 min on Linux, and this shows which tests are slow
  • CHANGELOG: tests entry

Not addressed here

  • The refused S3 connections from the Windows runner themselves (network/MPCDF side); other tests can still hit such a window.
  • test_gui_upload_task_missing_circle failed in the same run with RemoteDisconnected from dcor-dev. urllib3 counts that as a read error, and the API's Retry uses read=0, so the GET was not retried.

Testing
tests/test_gui.py passes locally on Linux (12 passed). CI cannot run the tests for fork PRs.

🤖 Generated with Claude Code

Each new main window restored the unfinished upload jobs of all
previous GUI tests and uploaded them again. A slow or failing
leftover upload then blocked the job the test was waiting for
(e.g. test_gui_upload_private on Windows).

Also print the 20 slowest tests in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.74%. Comparing base (bae8470) to head (672b774).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   72.84%   72.74%   -0.10%     
==========================================
  Files          72       72              
  Lines        6057     6057              
==========================================
- Hits         4412     4406       -6     
- Misses       1645     1651       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmueller
paulmueller merged commit 3f0c499 into DCOR-dev:main Nov 4, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants