Repository navigation
ref: remove the fallback to uploading resources via CKAN - #126
Merged
Merged
Conversation
DCOR only accepts uploads to S3 (DCOR-dev/ckanext-dcor_schemas#44). This also removes the requests_toolbelt dependency, which was only used for the legacy upload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
paulmueller-agent
force-pushed
the
remove-legacy-upload
branch
from
November 5, 2026 10:17
481ea42 to
577cd6a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 72.67% 72.99% +0.32%
==========================================
Files 72 72
Lines 6063 6029 -34
==========================================
- Hits 4406 4401 -5
+ Misses 1657 1628 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resource_addfell back to uploading resources via CKAN (resource_add_upload_legacy_indirect_ckan) when a server did not offer direct S3 uploads. All DCOR servers upload to S3, and DCOR-dev/ckanext-dcor_schemas#44 rejects uploads via CKAN, because such resources would never reach S3 since ckanext-dcor_depot 1.1.0.Changes
resource_add_upload_legacy_indirect_ckanand the fallback inresource_add. If a server does not offer S3 uploads,NoS3UploadAvailableErrornow propagates and the upload job goes into the error state with that message.resource_addstill returns(srv_time, etag);srv_timeis now always 0 (documented).requests_toolbeltdependency (only used for the legacy upload):pyproject.toml, the "Software" dialog, the PyInstaller hook.Testing
ruff and flake8 pass.
tests/test_api_dataset.py,tests/test_upload_job.py, andtests/test_cli_upload_task.pypass locally against DCOR-dev (36 passed). CI cannot run the tests for fork PRs.🤖 Generated with Claude Code