Repository navigation
tests: upload resources to S3 in package_revise tests - #2
Merged
Merged
Conversation
Uploading resources via CKAN is rejected since ckanext-dcor_schemas 1.3.0, before the checks these tests are about. Upload the resources to S3 first, so that the tests check that resources cannot be added to active datasets and that resource names must be unique again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_package_revise_upload_not_allowed_active_datasetandtest_package_revise_upload_not_allowed_same_resource_nameuploaded files via CKAN (update__resources__-1__upload). Since ckanext-dcor_schemas 1.3.0 (DCOR-dev/ckanext-dcor_schemas#44), such uploads are rejected (403) before the checks these tests are about, so they failed with an unexpected error message / status code.Both tests now upload the file to S3 first (new helper
upload_resource_to_s3, using DCOR-Aid's presigned upload) and then add the resource by itsidwithpackage_revise, like DCOR-Aid does. The assertions are unchanged:All 25 tests pass against DCOR-dev.
🤖 Generated with Claude Code