Skip to content

fix: install non-released versions: handle space - #8505

Merged
aldbr merged 3 commits into
DIRACGrid:integrationfrom
fstagni:fix_install_not_release
Apr 21, 2026
Merged

aldbr merged 3 commits into
DIRACGrid:integrationfrom
fstagni:fix_install_not_release

Conversation

@fstagni

@fstagni fstagni commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@fstagni
fstagni requested a review from andresailer as a code owner April 10, 2026 08:03
Comment thread src/DIRAC/FrameworkSystem/Service/SystemAdministratorHandler.py Outdated
Comment thread src/DIRAC/FrameworkSystem/Service/SystemAdministratorHandler.py Outdated
Comment thread src/DIRAC/FrameworkSystem/Client/SystemAdministratorClientCLI.py
@fstagni
fstagni force-pushed the fix_install_not_release branch 3 times, most recently from 475534f to 1ea0af8 Compare April 20, 2026 08:44
Comment thread src/DIRAC/FrameworkSystem/Service/SystemAdministratorHandler.py Outdated
@fstagni
fstagni force-pushed the fix_install_not_release branch from 1ea0af8 to 6a7640e Compare April 20, 2026 16:00
…_updateSoftware

Extract the version validation/normalisation logic and the filesystem
directory-label derivation into two module-level helper functions
(_normalise_version, _directory_label) so they can be unit-tested
directly without standing up a full DIRAC service.

Update the unit tests to import and exercise the real production
functions instead of maintaining local mirror implementations.
@fstagni
fstagni requested a review from aldbr April 20, 2026 16:06
Comment thread src/DIRAC/FrameworkSystem/Service/SystemAdministratorHandler.py Outdated
@fstagni
fstagni force-pushed the fix_install_not_release branch from dff5946 to c6971fe Compare April 21, 2026 08:59
@aldbr
aldbr merged commit e5bd326 into DIRACGrid:integration Apr 21, 2026
23 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Apr 21, 2026
@fstagni
fstagni deleted the fix_install_not_release branch October 20, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sweep:ignore Prevent sweeping from being ran for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants