Repository navigation
[8.0] fix (RMS): stop the ReqProxy from dropping the operations of cached requests - #8834
Merged
fstagni merged 2 commits intoOct 19, 2026
Conversation
…equests Request.__init__ and Operation.__init__ deleted the "Operations"/"Files" key from the dict they were given. Since c467386 the ReqProxy saves the dict it passed to Request() rather than the original JSON, so every request forwarded through a ReqProxy was stored without any operations. (cherry picked from commit ad9fac6)
…n them When a Waiting request has no operation to execute (e.g. it has no operations at all), RequestTask crashed with "'NoneType' object has no attribute 'Type'" and the agent picked the request up again a few minutes later, forever. Set an error on the request and delay it by a day instead, so it stays available for recovery. (cherry picked from commit 42d3a88)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8832.
On this branch the ReqProxy still saves the original JSON, so cached requests are not losing their operations here (that only happens since c467386, which is only on integration). The backport still fixes:
Request.__init__andOperation.__init__no longer modify the dict they are given, which also means the ReqProxy's__forwardable()check sees the operations again.RequestTaskno longer crashes repeatedly on aWaitingrequest that has no operation to execute (e.g. all its operations areCanceled); it sets an error on the request and delays it by a day.BEGINRELEASENOTES
*RequestManagement
FIX: The RequestExecutingAgent no longer crashes repeatedly on requests without any operation to execute, it sets an error and delays them by a day
CHANGE: Request and Operation constructors no longer modify the dictionary they are given
ENDRELEASENOTES