Repository navigation
[9.1] fix (DMS): presigned URLs from the S3Gateway - #8835
Merged
fstagni merged 1 commit intoOct 19, 2026
Merged
Conversation
Accessing an S3 storage element through the S3Gateway was broken with S3
implementations which validate presigned requests:
- the gateway looked up urls.get("Fields") instead of the fields of each URL,
so the checksum metadata was never stored on upload
- boto does not add the Fields of generate_presigned_post to the policy, so
once passed S3 rejected them as "Extra input fields"
- exists() sent a GET to a URL signed for HEAD, which is rejected as Forbidden
chrisburr
requested review from
andresailer,
atsareg,
chaen and
fstagni
as code owners
October 19, 2026 13:33
This was referenced Oct 19, 2026
fstagni
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes presigned URLs from the S3Gateway, which only worked because S3Mock doesn't validate them (found in #8831):
urls.get("Fields")instead of the fields of each URL)exists()sent a GET to a URL signed for HEADBEGINRELEASENOTES
*DataManagement
FIX: S3Gateway presigned URLs work with S3 implementations which validate them, and store the checksum on upload
ENDRELEASENOTES