Repository navigation
fix: CI workflow fixes for the central repository - #288
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI fixes, both needed because the central
DIRACGrid/Pilotrepository is not the place where everything can run:checkAllCommitMessages: 'true'validates every commit in a PR, including theMerge pull request #...commits that any devel→master sync PR contains. Those never match the<type>(<scope>): <subject>pattern, so every newMaster PR fails the check (see PR newMaster_20261020: merge devel into master #287). The pattern now also accepts merge commit subjects.HOSTCERT_BASE64and access to the CERN certification CEs). They are now skipped on the central repository viaif: github.repository_owner != 'DIRACGrid'on every job, while still running on pushes to forks.Evidence
- failed: "Merge pull request #285 from maxnoe/generic-option-list", while all real commits pass.integrationworkflow run fails/cancels on every push todevel(e.g. runs 32864919075, 35835405066) because the CERN-only secrets and CEs are not available on the central repository.Merge Danger
Door: two-way — revert the merge commit to restore the previous behaviour.
Blast Radius: CI only. No production code is touched. Risk: a genuinely malformed commit message could now hide behind a merge commit line in a PR containing merges; integration regressions will only be visible on the private forks that run the workflow.