Repository navigation
fix(tasks): fix failed task injection rollback - #1105
Draft
francescobrivio wants to merge 1 commit into
Draft
francescobrivio wants to merge 1 commit into
francescobrivio wants to merge 1 commit into
Conversation
chrisburr
reviewed
Oct 23, 2026
| # Cancelled again while cleaning up: let it propagate | ||
| logger.debug("Cancelled while closing exit stack", exc_info=True) | ||
| raise | ||
| except BaseException: |
Contributor
Author
There was a problem hiding this comment.
I took it from the suggested-fix code snippet, but it's indeed probably not needed, I'll revert it back to Exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Related to #1101.
In this PR I'm fixing the issue where a failing-task injection isn't rolled back correctly in all cases.
The changes include the fix suggested in the original issue, plus an additional protection against cases in which the the task is cancelled again while the cleaning up is still ongoing.
PR Validation
As usual, implementing the tests is taking me longer than the rest 😄 work in progress