Feature: Add subelement scheme for quad and triangle hanging node resolution - #2395
Feature: Add subelement scheme for quad and triangle hanging node resolution#2395lenaploetzke wants to merge 43 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
+ Coverage 82.36% 82.45% +0.08%
==========================================
Files 125 131 +6
Lines 20708 21387 +679
==========================================
+ Hits 17056 17634 +578
- Misses 3652 3753 +101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spenke91
left a comment
There was a problem hiding this comment.
Thanks a lot @lenaploetzke for this great feature! I'm glad to see the subelement concept being molded into an actual implementation 👍
I like the overall code design and think it is great that we barely have to change the interface of the normal schemes. As you will see in one of the comments, I feel like we might be missing one layer of inheritance between "a subelement scheme for triangles" and "a subelement schemes for triangles that resolves haning nodes".
Aside from that, most of my comments are minor suggestion and remarks, as usual :-)
| 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
|
|
||
| /** \file t8_scheme_tri.hxx |
There was a problem hiding this comment.
I would suggest to use more descriptive names for these two files. I know the context is clear from the path, but the path is often not shown, e.g., in vs code. So maybe something like t8_subelement_scheme_tri.hxx or t8_scheme_hanging_nodes_tri.hxx?
There was a problem hiding this comment.
I also like this but i wait for the decision with the abstraction layer before doing this
Co-authored-by: spenke91 <thomas.spenke@dlr.de>
Closes #2396
Describe your changes here:
This PR adds a general subelement scheme with specializations for quad and triangle hanging node resolution. It also provides two examples and one test.
I implemented only the functions necessary for the visualization. Next steps are all functions necessary for simulations. This means for example neighbors.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).