Skip to content

Feature: Add subelement scheme for quad and triangle hanging node resolution - #2395

Open
lenaploetzke wants to merge 43 commits into
mainfrom
subelement_quads
Open

Feature: Add subelement scheme for quad and triangle hanging node resolution#2395
lenaploetzke wants to merge 43 commits into
mainfrom
subelement_quads

Conversation

@lenaploetzke

@lenaploetzke lenaploetzke commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Closes #2396

Describe your changes here:
This PR adds a general subelement scheme with specializations for quad and triangle hanging node resolution. It also provides two examples and one test.
I implemented only the functions necessary for the visualization. Next steps are all functions necessary for simulations. This means for example neighbors.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • README.md files are updated if necessary.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.81752% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.45%. Comparing base (85c9c9d) to head (2c806b7).

Files with missing lines Patch % Lines
.../t8_schemes/t8_subelement/t8_subelement_scheme.hxx 76.67% 80 Missing ⚠️
.../t8_subelement/specializations/t8_scheme_quads.hxx 91.66% 8 Missing ⚠️
...es/t8_subelement/specializations/t8_scheme_tri.hxx 90.58% 8 Missing ⚠️
src/t8_forest/t8_forest_subelement.cxx 94.80% 4 Missing ⚠️
src/t8_schemes/t8_scheme.hxx 85.71% 2 Missing ⚠️
src/t8_forest/t8_forest_adapt.cxx 91.66% 1 Missing ⚠️
src/t8_schemes/t8_subelement/t8_subelement.cxx 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
+ Coverage   82.36%   82.45%   +0.08%     
==========================================
  Files         125      131       +6     
  Lines       20708    21387     +679     
==========================================
+ Hits        17056    17634     +578     
- Misses       3652     3753     +101     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ole-alb ole-alb assigned ole-alb and unassigned ole-alb Aug 17, 2026
Comment thread src/t8_schemes/t8_scheme.cxx Outdated
@spenke91
spenke91 self-requested a review August 17, 2026 13:03
@spenke91 spenke91 self-assigned this Aug 17, 2026

@spenke91 spenke91 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lenaploetzke for this great feature! I'm glad to see the subelement concept being molded into an actual implementation 👍
I like the overall code design and think it is great that we barely have to change the interface of the normal schemes. As you will see in one of the comments, I feel like we might be missing one layer of inheritance between "a subelement scheme for triangles" and "a subelement schemes for triangles that resolves haning nodes".

Aside from that, most of my comments are minor suggestion and remarks, as usual :-)

Comment thread test/t8_gtest_adapt_callbacks.cxx Outdated
Comment thread test/t8_gtest_adapt_callbacks.cxx Outdated
Comment thread test/t8_gtest_adapt_callbacks.hxx Outdated
Comment thread src/t8_schemes/t8_subelement/README.md Outdated
Comment thread src/t8_schemes/t8_subelement/t8_subelement_scheme.hxx Outdated
Comment thread example/subelements/t8_hanging_nodes_shock.cxx Outdated
Comment thread example/subelements/t8_hanging_nodes_shock.cxx Outdated
Comment thread example/subelements/t8_hanging_nodes_shock.cxx Outdated
Comment thread example/subelements/t8_hanging_nodes_shock.cxx Outdated
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

/** \file t8_scheme_tri.hxx

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to use more descriptive names for these two files. I know the context is clear from the path, but the path is often not shown, e.g., in vs code. So maybe something like t8_subelement_scheme_tri.hxx or t8_scheme_hanging_nodes_tri.hxx?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like this but i wait for the decision with the abstraction layer before doing this

@spenke91 spenke91 assigned lenaploetzke and unassigned spenke91 Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add subelement scheme for quad and triangle hanging node resolution

4 participants