Conversation
Reading a transform, metric or dimension meant copying a name out of its query and searching for it to get to the node it came from. The names in the query are now links. What gets linked is the node's own parents, which DJ already derived by parsing that same query, so the links can only point at real upstreams and cannot drift from what the query says. They arrive with the node payload, so nothing new is fetched. The highlighter splits a dotted name across several tokens, so a match is found on the full text of a row and the tokens are then split at its boundaries. Tokens outside a match keep the styling they came with, and a row with no match is handed back to the highlighter untouched. A name only counts when it stands alone: `default.orders` does not match inside `default.orders_archive`, and where one parent's name prefixes another's, the longer wins. A link keeps the code block's type and colour in every state, marked only by a faint dotted rule. The page's own link styling pulled the name out of the monospace run and broke the alignment of the SQL around it, and the global `a:hover` outranks a bare class, so the selectors carry the element. The block also loses the vertical half of the highlighter's 2rem padding, which read as dead space above and below the query. Names written inside comments or string literals are linked too, and a source node referenced by its physical table name rather than its node name is not. Both seemed worth leaving until someone hits them.
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan