Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: I tested this pr with both a built appmage and my flatpak packaging myself. Codex, however wrote the majority of this pr and the achtual code changes.
this is how it looked before


and after
Linux optical drives discovered through sysfs currently appear in the drive dropdown only as
/dev/sg*, making multiple drives difficult to distinguish. Read optionalvendorandmodelattributes from the already-discovered SCSI device and show choices such as/dev/sg3 — PLEXTOR CD-R PX-W4012A.The selected value and redumper argument remain the original device path. Missing, blank, or unreadable metadata falls back to the plain path; partial metadata remains useful. Normalize padded SCSI whitespace. Windows/macOS enumeration and displayed choices are unchanged. The compact selected-path control remains unchanged, with its existing adjacent description showing the model; egui already expands the open menu to fit its labels. No dependencies or packaging changes.
Validation:
cargo test --locked: 3 tests passed (vendor/model normalization, partial metadata, missing/blank/read-failure/disconnected-device fallbacks).cargo fmt --all -- --checkandgit diff --check: passed.cargo clippy --locked --all-targets: completed; warning messages/counts match an untouched checkout of base commit65028e7. Strict-D warningsfails on the existingbuild.rsclippy::get_firstwarning.src/drives.rsreturned/dev/sg1 — Generic External,/dev/sg2 — TSSTcorp DVD-ROM SH-D163B, and/dev/sg3 — PLEXTOR CD-R PX-W4012A, both on the Bazzite host and inside the installed Redumper-GUI Flatpak. The Flatpak run granted temporary read-only access only to the probe directory; existing device permissions were unchanged. No optical-device commands were issued.Packaging and limits: