Repository navigation
fix: scope workflow secrets and restore Actions execution - #30
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent scheduled deployments never start: GitHub flags the workflow as potentially malicious and requires approval. Run #9232 is
action_required; older run #9202 failed because its approval expired. The workflow currently serializes every available secret into the runner environment, a likely trigger for this review.Remove bulk secret export from both workflows. Pass only the supported SMTP and webhook secrets directly to the deployment step; document explicit mappings for custom config variables. PR checks receive no repository secrets.
Also correct the initial PR history from an array to the object expected by the application, stop suppressing application failures, and validate nonempty HTML plus object-shaped JSON before deployment. Clone previous Pages data into an explicit directory so history survives repository renames or capitalization changes. Build the command by its Go package path.
Validation:
go test ./...,make build, andgo vet ./...passed.git diff --checkpassed.GitHub's security classification does not identify the exact triggering line. The new PR check verifies whether the revised workflow is accepted; the production deployment still needs a run after this change is merged.