Skip to content

fix: scope workflow secrets and restore Actions execution - #30

Merged
WCY-dt merged 1 commit into
mainfrom
codex/fix-actions-secret-export
Oct 25, 2026
Merged

WCY-dt merged 1 commit into
mainfrom
codex/fix-actions-secret-export

Conversation

@WCY-dt

@WCY-dt WCY-dt commented Oct 25, 2026

Copy link
Copy Markdown
Member

Recent scheduled deployments never start: GitHub flags the workflow as potentially malicious and requires approval. Run #9232 is action_required; older run #9202 failed because its approval expired. The workflow currently serializes every available secret into the runner environment, a likely trigger for this review.

Remove bulk secret export from both workflows. Pass only the supported SMTP and webhook secrets directly to the deployment step; document explicit mappings for custom config variables. PR checks receive no repository secrets.

Also correct the initial PR history from an array to the object expected by the application, stop suppressing application failures, and validate nonempty HTML plus object-shaped JSON before deployment. Clone previous Pages data into an explicit directory so history survives repository renames or capitalization changes. Build the command by its Go package path.

Validation:

  • Go 1.24.5: go test ./..., make build, and go vet ./... passed.
  • actionlint 1.7.12 and git diff --check passed.
  • Ran the binary twice in an isolated directory: verified valid JSON/HTML and growing service history.

GitHub's security classification does not identify the exact triggering line. The new PR check verifies whether the revised workflow is accepted; the production deployment still needs a run after this change is merged.

Copilot AI balanced review requested due to automatic review settings October 25, 2026 11:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@WCY-dt
WCY-dt merged commit 38b3197 into main Oct 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants