Repository navigation
test(generator): add text/binary classification fixtures (SW-034) - #286
Merged
dDevAhmed merged 1 commit intoOct 21, 2026
Conversation
Prove that template generation correctly distinguishes substitutable text
content from binary content:
- text files (no NUL bytes) receive only the allowlisted {{projectName}}
and {{templateId}} substitutions, including multi-occurrence, nested
subdirectory, empty, whitespace-only, and brace-only cases
- binary files (containing at least one NUL byte) are copied byte-for-byte
with no token expansion, regardless of file extension; verified with
leading/trailing/mid-buffer NUL positions, all-byte sweep (0x00..0xFF),
token strings embedded inside binary payloads, and zero-length files
- classification is purely byte-level and deterministic: same buffer always
produces the same outcome across independent template trees and repeated
calls; boundary test confirms a single NUL flips text → binary
- mixed templates process text and binary siblings at every nesting depth
without cross-contamination
Closes DigiNodes#136
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prove that template generation correctly distinguishes substitutable text content from binary content:
Closes #136
Summary
Related Issue
Closes #
Scope
Testing
Security Impact
Security notes:
Release Impact
No published/user-visible behavior change
Patch
Minor
Breaking/pre-1.0 contract change
Changeset included where required
Changeset not required; reason explained below
Release notes:
Documentation
Checklist
docs/contributing/wave-architecture.mdfor Stellar Wave work