Skip to content

Add API Service package metadata conformance - #287

Merged
dDevAhmed merged 1 commit into
DigiNodes:mainfrom
angelannaji92-cyber:sw-043-api-service-package-metadata
Oct 21, 2026
Merged

dDevAhmed merged 1 commit into
DigiNodes:mainfrom
angelannaji92-cyber:sw-043-api-service-package-metadata

Conversation

@angelannaji92-cyber

Copy link
Copy Markdown

Summary

Add conformance tests for the generated API Service package metadata and scripts to ensure they match the frozen starter contract. This helps prevent unintended changes to package configuration, scripts, and runtime dependencies.

Related Issue

Closes #145

Scope

  • Validate generated API Service package metadata against the frozen starter contract.
  • Verify required package scripts and their expected values.
  • Check that no unintended runtime dependencies or secrets are introduced.
  • Add or update focused tests to catch metadata and script regressions.
  • Keep changes limited to the API Service template and its conformance tests.
  • Leave unrelated templates and behavior unchanged.

Testing

  • Tests added/updated where applicable
  • Existing relevant tests pass
  • Lint/type/build checks pass where available

Planned verification:

  • Run the focused API Service package metadata conformance tests.
  • Run the relevant template and generator test suites.
  • Run repository lint, typecheck, and build checks where available.

Security Impact

  • No security-sensitive behavior is changed
  • Security-sensitive behavior is changed and explained below

Security notes:

This change validates package metadata and scripts without intentionally changing runtime security behavior. Tests will also check that generated package metadata does not introduce secrets or unintended runtime dependencies.

Release Impact

  • No published/user-visible behavior change

  • Patch

  • Minor

  • Breaking/pre-1.0 contract change

  • Changeset included where required

  • Changeset not required; reason explained below

Release notes:

This is a template conformance and testing change. No release-facing behavior change is intended, so a changeset should not be required unless repository policy specifies otherwise.

Documentation

  • Documentation updated where applicable
  • No documentation change required

The existing frozen starter contract and repository guidance define the expected behavior; this change focuses on automated validation.

Checklist

  • I read docs/contributing/wave-architecture.md for Stellar Wave work
  • I stayed within the agreed issue scope
  • I checked for overlapping open contributor PRs
  • I did not include secrets or sensitive data
  • I reviewed new/updated dependencies if any
  • I considered failure/error paths, not only the happy path
  • I am not disclosing an unresolved vulnerability publicly

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6b510512-e65c-4c6f-8e6e-1a4053c04cb1
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dDevAhmed
dDevAhmed merged commit 8429c25 into DigiNodes:main Oct 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SW-043 — Add API Service package metadata conformance

2 participants