Repository navigation
test(templates): validate generated Smart Contract Cargo metadata - #289
Open
ademolabiyi92-design wants to merge 2 commits into
Open
ademolabiyi92-design wants to merge 2 commits into
ademolabiyi92-design wants to merge 2 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Cargo metadata conformance coverage for generated Smart Contract projects, and repair the production compilation errors that prevented the linked CLI smoke job from running.
Related Issue
Closes #148
Scope
Testing
Windows / Node 24.21.0, Rust/Cargo 1.98.1:
npm ci --ignore-scripts --no-audit --no-fund: passed.npm run build: passed; all 12 production TypeScript errors resolved.git diff --check: passed.--maxWorkers=2): 1,757 passed, 29 failed, 5 skipped. Remaining failures are in unchanged suites, including Windows symlink permissions, workflow policy checks and other existing behavior; the previous run had 70 failures.Security Impact
Restore references to the already-defined redaction expressions; existing secret-fixture tests pass. Timeout classification uses the structured error code and does not expose raw process output. The protected
src/output/redaction.tsfix and changeset require maintainer scope review: issue #148 currently lacks theprotected-surfacelabel enforced by the PR guard. No guard or workflow is weakened.Release Impact
Restore CLI compilation, diagnostic timeout guidance and the existing output-redaction pipeline.
Documentation
Checklist