Repository navigation
Follow-ups to :open: namespace check, open IDL reflection, tests - #1292
Open
staging-devin-ai-integration[bot] wants to merge 2 commits into
Open
staging-devin-ai-integration[bot] wants to merge 2 commits into
staging-devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to #1007 (
:openfor<details>/<dialog>):ElementData::flush_open_statenow setsElementState::OPENonly for an HTML-namespacedetails/dialogthat has a null-namespaceopenattribute. Theset_attribute/clear_attributehooks in the mutator likewise ignore namespacedopenattrs. Before this, the check used local names only, so e.g. an SVG-namespacedetails, or a namespacedopenattribute, would also set the state.openproperty ondetails/dialog(el.open = truesetsopen=""through the mutator;el.open = falseremoves it). Other elements returnundefinedand ignore assignment. Without this, WPTs that toggledetails.openfrom script could not pass.details:open > prule, and the snapshot holds the pre-change OPEN state.openreflection.WPT (main 53e9d81 → this branch)
css/selectors: 415 → 417 tests passing, 2501 → 2504 subtests, no regressions.selectors-4/details-open-pseudo-002.html: FAIL → PASSselectors-4/details-open-pseudo-003.html: FAIL → PASSopen-pseudo.html: 0/3 → 1/3 ("The details element should support :open" now passes; the remaining subtests need dialogshow()and select pickers)html/semantics/interactive-elements/the-details-element: 14 → 15 subtests passing, and no test that passed before fails now. Two tests change status only because they now get past their initial.openassertions:details-keyboard-activation.html: FAIL → SKIP. It now reachestest_driver.send_keys, which the runner skips because it isn't supported.name-attribute.html: one subtest FAIL → PASS. The test as a whole goes FAIL → TIMEOUT because it now waits for atoggleevent.toggleevents and exclusivenamegroups aren't implemented.fmt and clippy are clean;
cargo test -p blitz-dom(85 tests) andcargo test -p blitz-vibey-scriptpass.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/97e220fc0ea344feb49da2f7a9635913
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/97e220fc0ea344feb49da2f7a9635913?variant=devin-insiders
WPT results
Subtests: 3 newly passing, 0 newly failing (net +3).
Subtest changes by area (3 areas)
Full diff (3 changed tests)
Generated by the WPT workflow.