Skip to content

Follow-ups to :open: namespace check, open IDL reflection, tests - #1292

Open
staging-devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1793034494-open-pseudo-followups
Open

staging-devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1793034494-open-pseudo-followups

Conversation

@staging-devin-ai-integration

@staging-devin-ai-integration staging-devin-ai-integration Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-ups to #1007 (:open for <details>/<dialog>):

  • ElementData::flush_open_state now sets ElementState::OPEN only for an HTML-namespace details/dialog that has a null-namespace open attribute. The set_attribute/clear_attribute hooks in the mutator likewise ignore namespaced open attrs. Before this, the check used local names only, so e.g. an SVG-namespace details, or a namespaced open attribute, would also set the state.
  • blitz-vibey-script now reflects the boolean open property on details/dialog (el.open = true sets open="" through the mutator; el.open = false removes it). Other elements return undefined and ignore assignment. Without this, WPTs that toggle details.open from script could not pass.
  • Tests:
    • blitz-dom: opening and closing via the mutator and via a summary click restyles a details:open > p rule, and the snapshot holds the pre-change OPEN state.
    • blitz-dom: namespace cases.
    • blitz-vibey-script: open reflection.

WPT (main 53e9d81 → this branch)

css/selectors: 415 → 417 tests passing, 2501 → 2504 subtests, no regressions.

  • selectors-4/details-open-pseudo-002.html: FAIL → PASS
  • selectors-4/details-open-pseudo-003.html: FAIL → PASS
  • open-pseudo.html: 0/3 → 1/3 ("The details element should support :open" now passes; the remaining subtests need dialog show() and select pickers)

html/semantics/interactive-elements/the-details-element: 14 → 15 subtests passing, and no test that passed before fails now. Two tests change status only because they now get past their initial .open assertions:

  • details-keyboard-activation.html: FAIL → SKIP. It now reaches test_driver.send_keys, which the runner skips because it isn't supported.
  • name-attribute.html: one subtest FAIL → PASS. The test as a whole goes FAIL → TIMEOUT because it now waits for a toggle event. toggle events and exclusive name groups aren't implemented.

fmt and clippy are clean; cargo test -p blitz-dom (85 tests) and cargo test -p blitz-vibey-script pass.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/97e220fc0ea344feb49da2f7a9635913
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/97e220fc0ea344feb49da2f7a9635913?variant=devin-insiders

WPT results

Subtests: 3 newly passing, 0 newly failing (net +3).

Subtest changes by area (3 areas)
+ css             | +3 (+3 / -0) | 59.61% -> 59.61% (+0.00%) | 118801 -> 118804 / 199286
+   selectors     | +3 (+3 / -0) | 48.52% -> 48.58% (+0.06%) |   2505 ->   2508 /   5163
+     selectors-4 | +2 (+2 / -0) | 20.51% -> 25.64% (+5.13%) |      8 ->     10 /     39
Full diff (3 changed tests)
+ FAIL => FAIL  [1/3]  +1  css/selectors/open-pseudo.html
+ FAIL => PASS  [1/1]  +1  css/selectors/selectors-4/details-open-pseudo-002.html
+ FAIL => PASS  [1/1]  +1  css/selectors/selectors-4/details-open-pseudo-003.html

Generated by the WPT workflow.

Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: Staging-Devin AI <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants