Repository navigation
Keep driver tap callbacks separate - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering a
RecurrSchedule::tap()callback also changes the callback used by the Cron and php-rrule drivers. They share one inherited static property, so typed callbacks can throw aTypeError, and registering or clearing one driver's callback overwrites the others.Store callbacks by concrete driver class so each driver can be configured and reset independently. Subclasses are isolated as well. The
tap()API and callback arguments stay the same.Validated with the full Pest suite (143 tests) and Pint.
Fixes #20.