Repository navigation
Prevent authentication after a failed STARTTLS handshake - #193
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server accepts STARTTLS but the TLS handshake fails,
ImapConnectioncontinues to authenticate over the unencrypted connection. This can send a password or OAuth token in plain text.This checks that encryption was established before continuing. If it wasn't, we disconnect and throw
ImapConnectionFailedException.I reproduced the issue with a local TCP server and confirmed that the fix prevents credentials from being sent. All 386 unit tests pass.
Closes #192.