Repository navigation
Conversation
… controls asset-maintenance (DistinctCodes#1477, DistinctCodes#1478, DistinctCodes#1479): - reject logging maintenance against a detokenized/reactivated asset - add an admin-gated emergency pause covering every mutating entrypoint - add amend/void flags so a mistaken maintenance record can be corrected without erasing history assetsup (DistinctCodes#1496): - maintain an admin-managed WASM-hash allowlist and require the new hash to be approved before `upgrade` runs Also consolidate the assetsup Error enum (61 -> 49 variants) to fit the 50-case contract-spec limit, and repair pre-existing test-build breakage in both crates so `cargo test` compiles. Closes DistinctCodes#1477 Closes DistinctCodes#1478 Closes DistinctCodes#1479 Closes DistinctCodes#1496
|
@Ummi-001 is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Ummi-001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1477,
Closes #1478,
Closes #1479,
Closes #1496.
asset-maintenancepause/unpause(is_paused) covering every mutating entrypoint. The existing source-drivenevery_mutating_entrypoint_is_coveredguard test was extended to the new entrypoints, andPAUSE_EXEMPTdocuments each deliberate exemption.mark_asset_detokenized/reactivate_asset/is_asset_detokenizedplus a guard that rejects logging maintenance against a detokenized asset, withAssetDetokenizedand events.void_maintenance_record/amend_maintenance_record(plusis_maintenance_record_voided,get_maintenance_amendment,get_maintenance_void). Voided records are excluded from, and amendments folded into, theAssetStatsrollup viarecompute_asset_stats.assetsupapprove_wasm_hash/revoke_wasm_hash/is_wasm_hash_approved) is now enforced inupgrade; upgrading to an unapproved hash fails withWasmHashNotApproved.Housekeeping
assetsupErrorenum from 61 to 49 variants so it fits the 50-case contract-spec limit, with a regression test (the_error_enum_fits_the_contract_spec_limit) and the retired codes recorded incontracts/ERRORS.md.should_panicassertions on renumbered codes, a duplicate integration-test name, a TTL test usingResultaccessors on non-Resultreturns), so this change compiles and runs.Testing
All three pass for the two touched crates.
Note on repository state
At the time of writing,
maindoes not build:multisig-transferand thecontribtest target have pre-existing compile errors (andcargo fmt --all --checkreports unrelated diffs). Those are untouched here; this PR is limited to the crates relevant to the linked issues.