Skip to content

Customer pages (payments, credits, usage, register, login) lack page-level tests #1990

Closed
#2062
Closed
Customer pages (payments, credits, usage, register, login) lack page-level tests#1990
#2062
Assignees
ObedChibunna
Labels
NextJSStellar WaveIssues in the Stellar wave programenhancementNew feature or requestfrontend

Description

@yusuftomilola
yusuftomilola
opened on Oct 16, 2026

Problem

Unit tests exist for helpers (payments-api, credits-api, utils) and for the auth form, but app/payments/new, app/payments/[id], app/payments/metrics, app/payments/return (partly), app/credits, app/usage and app/wallet/error.tsx have no component tests, so flows such as payment creation and status polling are untested.

Proposed change

Add tests for rendering, loading, error and empty states, the idempotency-key handling on payment creation, and the websocket/poll fallback behaviour for payment status.

Acceptance criteria

  • Each page has at least a loading, error and success test.

Activity

  1. yusuftomilola
    added
    enhancementNew feature or request
    frontend
    NextJS
    on Oct 16, 2026
  2. drips-wave
    added
    Stellar WaveIssues in the Stellar wave program
    on Oct 17, 2026

  3. Asekhame commented on Oct 17, 2026

    @Asekhame
    Asekhame
    on Oct 17, 2026 – with Drips Wave

    @Asekhame has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi, I would love to work on this issue because I have worked on similar issues, and I can get it done within 24hrs.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Asekhame to this issue.

  4. victorocheje commented on Oct 17, 2026

    @victorocheje
    victorocheje
    on Oct 17, 2026 – with Drips Wave

    @victorocheje has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @victorocheje to this issue.

  5. DatboiCaleb commented on Oct 17, 2026

    @DatboiCaleb
    DatboiCaleb
    on Oct 17, 2026 – with Drips Wave

    @DatboiCaleb has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Good day Maintainer

    I'm a smart contract and full-stack developer who turns complex ideas into secure, production-ready blockchain code. With strong skills in Rust and Solidity, I build systems that are fast, safe, and built to last. My experience with the Stellar SDK and Soroban lets me ship real-world Web3 solutions that actually move value.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @DatboiCaleb to this issue.

  6. Manager-dev1515 commented on Oct 17, 2026

    @Manager-dev1515
    Manager-dev1515
    on Oct 17, 2026 – with Drips Wave

    @Manager-dev1515 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Why I want to work on this: The payment creation and status-polling flows are the parts of this app where a bug is expensive — a duplicate charge from missing idempotency handling, or a payment that never resolves because the websocket fallback to polling isn't exercised. Those flows are currently untested at the page level, so the helpers are tested in isolation but the composition — the thing a customer actually hits — isn't. I want to add tests that pin the loading, error, and success states of each page, plus the two behaviors the issue calls out specifically: idempotency-key handling on creation and the poll fallback for status. Those two are the tests that would catch a real regression; the state tests keep the pages honest about what they render.

    Relevant experience:

    Page-level tests for Next.js App Router pages — I've written tests for server and client pages using the repo's existing harness, distinguishing what's renderable in a component test (client pages, presentational state) from what needs a route-level or integration test (server component data fetching). I match the repo's existing pattern for the auth form rather than introduce a second testing style.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Manager-dev1515 to this issue.

  7. ObedChibunna commented on Oct 17, 2026

    @ObedChibunna
    ObedChibunna
    on Oct 17, 2026 – with Drips Wave
    Contributor

    @ObedChibunna has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Let me handle this issue as it is in line with my area of expertise

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @ObedChibunna to this issue.

  8. drips-wave commented on Oct 18, 2026

    @drips-wave
    drips-waveBot
    on Oct 18, 2026 – with Drips Wave

    Congratulations, @ObedChibunna! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @ObedChibunna: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  9. yusuftomilola
    assigned
    ObedChibunna
    on Oct 18, 2026
  10. ObedChibunna
    added a commit that references this issue on Oct 19, 2026

    Merge branch 'main' into Customer-pages-(payments,-credits,-usage,-re…

    d8bb3e8
  11. yusuftomilola
    closed this as completedin #2062on Oct 20, 2026
  12. yusuftomilola
    added a commit that references this issue on Oct 20, 2026

    Merge pull request #2062 from ObedChibunna/Customer-pages-(payments,-…

    2ab5198

  13. grantfox-oss commented on Oct 20, 2026

    @grantfox-oss
    grantfox-ossBot
    on Oct 20, 2026 – with GrantFox OSS

    🎉 This issue has been marked as completed on GrantFox!

    @ObedChibunna's PR #2062 was approved and merged by @yusuftomilola.

    🏆 @ObedChibunna: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (532 total points). Track your full progress on GrantFox.

    👏 Great work, @ObedChibunna! Keep contributing to DistinctCodes.

  14. drips-wave commented on Oct 20, 2026

    @drips-wave
    drips-waveBot
    on Oct 20, 2026 – with Drips Wave

    This issue has been completed by @ObedChibunna as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @ObedChibunna: You earned 150 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

NextJSStellar WaveIssues in the Stellar wave programenhancementNew feature or requestfrontend

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions