Repository navigation
Unify login return redirects - #2059
Merged
Merged
Conversation
Use only the validated returnTo parameter across middleware, admin guards, and the auth form. Preserve the full path and query string when redirecting after login, and remove all production of next. CLOSES DistinctCodes#1993
|
@ObedChibunna is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ObedChibunna Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use only the validated returnTo parameter across middleware, admin guards, and the auth form. Preserve the full path and query string when redirecting after login, and remove all production of next.
CLOSES #1993
Summary
Use only the validated returnTo parameter across middleware, admin guards, and the auth form. Preserve the full path and query string when redirecting after login, and remove all production of next.
Contracts checklist
If this PR touches anything under
contracts/, confirm it against thepre-deployment security checklist before
requesting review:
make audit(CT-72 require_auth() coverage) passes.+/-on amounts.contracts/.Test plan
Frontend CI checks passed.
Backend build, lint, dependency checks, critical audit, and unit tests passed.
Database-backed checks and Rust build checks remain unverified locally: PostgreSQL was unavailable, and the pinned Rust installation ran out of disk space.
Verified frontend lint, unit tests, typecheck, build, and E2E. Backend build, unit tests (714 passed), lint, dependency checks, and critical audit passed. Database checks and Rust builds remain unverified: PostgreSQL was unavailable, and installing the pinned Rust toolchain ran out of disk space.
CLOSES #1993