Fix validity bugs in AHFinderDirect, SphericalSurfaces and PunctureTracker - #67
Open
lucass-carneiro wants to merge 18 commits into
Open
lucass-carneiro wants to merge 18 commits into
lucass-carneiro wants to merge 18 commits into
Conversation
Added CapyrX thorns configuration to spacetimex.th
…d define prev. undefined data when necessary.
necessary when using cactus presync-only mode.
Contributor
Author
|
@lwJi Thanks for the review! I have added another |
lwJi
approved these changes
Sep 25, 2026
Collaborator
|
Looks good to me. Let's see what @rhaas80 says |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AHFinderDirect,SphericalSurfacesandPunctureTrackerhave several issues regarding undefined values and lack ofreads/writestatements in their schedules. When running with poisoning enabled, these undefined values either get caught but theCarpetXpoisoning system or cause the simulation to crash with null pointer dereferences.This pull request fixes those issues.