Repository navigation
fix(gateway): fix large audit snapshot memory - #52
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EitanWong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Hangzhou pilot state was 222 MB: ~163 MB audit, ~57 MB prior lease secrets. PR #50 prunes the expired lease secrets; this change preserves the full durable audit history but encodes its array one record at a time rather than running
json.MarshalIndentover the entire state. Gojson.Encoder.Encodebuffers each value, so encoding the full snapshot at once would not solve the peak-allocation issue. All other fields retain their JSON schema; the file remains atomically replaced with mode 0600.Verification: regression compares a 10k-event streamed file with standard JSON encoding, including notification secrets and permissions;
TMPDIR=/tmp bash scripts/check.shpasses (all tests, coverage, vet, UX smoke 17/17).This is a source fix only. Production requires separately authorized single-service deployment with backup, rollback, and RSS/state-size/restart trend checks; do not alter the Hangzhou instance from this PR.