Fix intermittent failure in feature_pegin_subsidy.py - #1576
Merged
delta1 merged 3 commits intoSep 1, 2026
Conversation
Member
|
Thanks @tomt1664 this looks good. Busy running it in a loop now. |
tomt1664
force-pushed
the
fix_intermittent_peginsubtest
branch
from
August 17, 2026 12:54
3b3ea8e to
bb4abaf
Compare
tomt1664
force-pushed
the
fix_intermittent_peginsubtest
branch
from
August 17, 2026 14:00
bb4abaf to
c6692e1
Compare
psgreco
added a commit
that referenced
this pull request
Sep 4, 2026
07e7159 test: fix fedpeg test to work with bitcoind parent (Byron Hambly) 2240b98 test: fix pegin subsidy test to work with bitcoind parent (Byron Hambly) a3f223b Fix intermittent failure in feature_pegin_subsidy.py (Tom Trevethan) Pull request description: backport of #1576 for elements-23.x branch ACKs for top commit: tomt1664: ACK 07e7159 tested locally Tree-SHA512: ef5f8851e893356639fe24ff5428a5f203d1c52ff5a5e0ab5702b351712f93905a24bc6abea9943f90a6ab60b53ded5063fa97286218f962768cf6d5ebb62728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature_pegin_subsidy.py has several assertions comparing the burn subsidy against hardcoded constants assumed fixed-length witness (t * 72 bytes per signature), but the actual subsidy is computed by the node from the parent-chain deposit transaction's real fee and vsize. DER-signature lengths on the parent-chain transaction vary by a byte or two causing a rare intermittent failure.
Replaced hardcoded subsidy values with a Python function that replicates
CheckPeginSubsidyAndMinimum's computation.