Skip to content

GH-855 Add per-feature enable/disable system via modules.yml - #1441

Open
vLuckyyy wants to merge 5 commits into
masterfrom
feature/module-toggle-feature
Open

vLuckyyy wants to merge 5 commits into
masterfrom
feature/module-toggle-feature

Conversation

@vLuckyyy

Copy link
Copy Markdown
Member

Fixes #855

Signed-off-by: Martin Sulikowski <vluckyyy.biznes@gmail.com>
@vLuckyyy
vLuckyyy requested a review from a team as a code owner September 22, 2026 19:50
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

📦 Development Build Ready

Warning

Do not use this build in production. It is intended for testing purposes only and may be unstable.

👉 Download EternalCore development build

Built with Java 25.

@vLuckyyy vLuckyyy changed the title Add per-feature enable/disable system via modules.yml GH-855 Add per-feature enable/disable system via modules.yml Sep 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34884efd0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7eb2d6fa4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f3684fe4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@imDMK imDMK left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job Lucky! looks great to me

@CitralFlo CitralFlo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local. Works good - I would highlight that it needs restart :P
Also @Rollczi should look at it because he is more advanced in Dependency Injection

Comment on lines +9 to +13
"#",
"# This file lets you completely disable individual EternalCore features.",
"#",
"# A feature set to 'false' will not register its commands, listeners, tasks or config section at all -",
"# it behaves as if it was never installed. This only takes effect on plugin startup, not on /reload.",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"#",
"# This file lets you completely disable individual EternalCore features.",
"#",
"# A feature set to 'false' will not register its commands, listeners, tasks or config section at all -",
"# it behaves as if it was never installed. This only takes effect on plugin startup, not on /reload.",
"#",
"# This file lets you completely disable individual EternalCore features.",
"#",
"# Works ONLY after server RESTART",
"# A feature set to 'false' will not register its commands, listeners, tasks or config section at all -",
"# it behaves as if it was never installed.",

@P1otrulla P1otrulla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👌

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modular features

4 participants