Repository navigation
refactor(headroom): generate the measurement matrix with combinatrix - #647
Merged
Merged
Conversation
The variant matrix is a constrained Cartesian product, so it is now a combinatrix model: the measured values of each setting are the dimensions, the rollout channel is a first-valid dimension, and HeadroomGlobalConfigSchema decides validity through a predicate constraint, so the schema stays the only statement of which settings are valid. The variants, their names and their order are unchanged. Exports the experimental feature list and the default mode and retrieval so the tests derive the expected count from them, and traces the measurement harness in knip so its script-only dependency is not reported as unused.
Mearman
marked this pull request as ready for review
October 29, 2026 10:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headroom measurement matrix was a hand-rolled constrained Cartesian product; it is now a combinatrix model, with HeadroomGlobalConfigSchema still the only statement of which settings are valid (through a predicate constraint) and the rollout channel derived as the first channel the schema accepts. The variants, their names and their order are unchanged.
This waits on the first combinatrix release: package.json pins combinatrix 1.0.0 as a devDependency (the harness is not part of the published package), which does not resolve on the registry yet, so pnpm-lock.yaml needs regenerating once it is published and CI will fail the frozen install until then.