Repository navigation
fix(frontdoor): keep Remote Control calls off the headroom hop so the tracker sees them - #650
Merged
Merged
Conversation
… tracker sees them The tracker observes an exchange through the route's own serve, and the headroom hop serves a request by forwarding it instead of calling serve. With headroom on for a session, every Remote Control call took the hop, so the tracker listed no sessions and the stream hub attached to none. The resolver wrapper now marks a request the tracker reads as not eligible for the hop. These calls carry no prompt for headroom to compress.
Mearman
marked this pull request as ready for review
October 29, 2026 08:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #648.
With headroom on for a session, the pipeline serves a request by forwarding it over the hop instead of calling the route's
serve. The Remote Control tracker observes exchanges by wrappingserve, so every Remote Control call took the hop unobserved:rc liststayed empty while the door's usage log recorded the same session's worker calls, and the stream hub attached to nothing. Those calls also failed whenever the headroom daemon reset a connection, which is most of theheadroom hop ... failedlines naming/v1/code/sessions.rcObservingResolvernow marks a request the tracker reads (isRcSessionExchange, the same test the tracker applies) as not eligible for the hop, so the route serves it and the observer runs. Those calls carry no prompt for headroom to compress. Model requests are unchanged.The pipeline test reproduces the bug: a worker call from a session that wants headroom reaches the route and the tracker, and a
/v1/messagescall under the same conditions still takes the hop. It fails without the resolver change.