Repository navigation
build: depend on combinatrix 2 - #653
Merged
Merged
Conversation
combinatrix 2 types a dimension's values as a non-empty list, so the measured lists are typed non-empty, and the measurement docs say the variant matrix is generated from the settings schema.
Mearman
marked this pull request as ready for review
October 29, 2026 13:40
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the headroom matrix to combinatrix 2, which makes trilean predicate trees the constraint language and types a dimension's values as a non-empty list. The measured lists are typed non-empty (each starts with the unset case, so none can be empty), and the Variants paragraph of the measurement docs now says the matrix is generated from the settings schema. The variant names, settings and order are unchanged; the existing matrix test passes as it is.
combinatrixandtrileanare now bare entries inminimumReleaseAgeExclude, as the org's other own packages are, instead of one entry per version.Fixes #652.