Repository navigation
feat: accept $schema in model data and offer more examples - #40
Merged
Merged
Conversation
A model file can name the JSON Schema it is written against, which an editor reads without any setting. parseModel and isModelData accept the key and ignore it, and the published schema declares it, so a file that names its schema validates against that schema.
…xamples The JSON view of a new model and of every example now starts with the $schema its release published, which the form keeps and no longer lists among the keys it does not show. The examples gain implications, numeric comparison, dead values, membership and negation, an unless exception, a derived fallback, chained activity and a space large enough for a covering array. Each is checked against the arithmetic of its dimensions and rules.
Mearman
marked this pull request as ready for review
October 30, 2026 09:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON view of a model never showed a
$schema, so an exported file got no editor validation.ModelDataand the published schema now accept the key (it is ignored byparseModel), and the explorer writes it first into every new model and every example, pointing at the schema of the release the page is built from. The form no longer lists it under keys it does not show.The example menu goes from three to eleven. The new ones cover implications, a numeric version floor, values no rule leaves possible (for the dead-value check), membership with any-of and not,
unless, a first-valid fallback, chainedactiveWhen, and a 189-combination space for covering arrays. Each count is checked against the arithmetic of its dimensions and rules rather than copied from the engine.The first commit is a
featto the package, so merging it releases a minor version. Until then the$schemaURL names the previous release, whose schema does not list the key, so an editor would flag it. The post-release redeploy rebuilds the site against the new version.