Repository navigation
Conversation
…ure calculation A NotReady node prints <unknown> as its MEMORY% in kubectl top nodes. The autoscaler treated that as a parse failure and lowered every pool to its floor for as long as the node stayed down. Such a node is now logged by name and skipped, and the worst case comes from the nodes that did report. The fail-safe still applies to a MEMORY% that is neither <unknown> nor a number, and, with its own message, when no node reported a percentage at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A NotReady node prints
<unknown>as its MEMORY% inkubectl top nodes. The autoscaler treated that as a parse failure and lowered every pool to its floor for as long as the node stayed down.Such a node is now logged by name and left out of the pressure calculation, so the worst case comes from the nodes that did report. The fail-safe stays for a MEMORY% that is neither
<unknown>nor a number, and, with its own message, for the case that no node reported a percentage (which would otherwise read as no pressure).The existing autoscaler tests that asserted the old behaviour now assert the new one, and new cases cover a single
<unknown>row among reporting nodes, every row<unknown>, a garbage percentage, and the worst reporting node still driving pressure next to an<unknown>row. With the old loop restored, the<unknown>tests fail.Closes #151