MenuItem decomposition - titleStyle migration by war-in · Pull Request #101225 · Expensify/App

war-in · 2026-09-15T15:48:15Z

Explanation of Change

Adds numberOfLines to MenuItem.Title/FieldValue and numberOfLinesValue to the MenuItemField preset, then migrates every callsite that only needed numberOfLinesTitle or title/row styles that turned out to be no-ops (styles.flex1 on the title, styles.moneyRequestMenuItem on the row). Adds a Phase 4 section to the comparison story.

Fixed Issues

$ #100159
PROPOSAL:

Tests

Open a workspace with report fields enabled: Workspace > More features > Report fields
Open a list-type report field that has several values, so List values holds a long comma-joined string
Verify that the value wraps and stops at 5 lines, and that pressing the row still opens the list values page
Go to Workspace > Members > Invite, select at least 10 members and continue to the message step
Verify that the Members row wraps its value onto at most 2 lines, and that pressing it goes back to the member selection
Create a distance expense and stop on the confirmation screen
Verify that the Rate, Tax rate, Tax amount, Time and Per diem rows render with the field name above the value, are vertically aligned with the untouched rows around them, and keep the same horizontal padding
Submit the expense, open it from the report, and verify that the same rows in the expense details view are unchanged and still open their edit pages
Open a car or hotel trip from a travel booking
Verify that the Cancellation row wraps onto at most 2 lines
Log out, open a share link so the app is in the anonymous state, then open a QR code page with a downloadable code
Press Download and verify that the QR code downloads instead of the app signing you out
Run Storybook (npm run storybook) and open Components/MenuItemComparison
Verify that in the Phase 4 — title styles section every card renders its legacy, composable and preset rows identically

Offline tests

N/A

QA Steps

Same as tests (1-12, 13 & 14 are dev only)

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…em` & `styles.flex1`

codecov · 2026-09-15T16:19:32Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...em/leaves/content/base/BaseMenuItemPrimaryText.tsx	`100.00% <100.00%> (ø)`
src/components/MenuItem/presets/MenuItemField.tsx	`100.00% <100.00%> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`82.11% <ø> (ø)`
...pendRules/configuration/SpendRuleMerchantsBase.tsx	`96.87% <ø> (ø)`
src/pages/ProfilePage.tsx	`88.23% <ø> (ø)`
src/pages/Travel/CarTripDetails.tsx	`0.00% <ø> (ø)`
src/pages/Travel/HotelTripDetails.tsx	`96.77% <ø> (ø)`
src/pages/settings/Wallet/ReportCardLostPage.tsx	`0.00% <ø> (ø)`
...pyPolicySettings/CopyPolicySettingsConfirmPage.tsx	`89.70% <100.00%> (ø)`
...sifyCard/issueNew/spendRules/SetSpendRulesStep.tsx	`0.00% <ø> (ø)`
... and 13 more
... and 10 files with indirect coverage changes

melvin-bot · 2026-09-15T16:19:36Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2026-09-15T19:05:33Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

# Conflicts: # src/pages/workspace/fields/CreateFieldsPage.tsx # src/pages/workspace/fields/FieldsValueSettingsPage.tsx

# Conflicts: # src/components/MoneyRequestConfirmationList/sections/PerDiemFields.tsx # src/stories/MenuItemComparison.stories.tsx

Pujan92 · 2026-09-18T12:04:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-09-18.at.19.10.44.mov

Pujan92

LGTM!

roryabraham · 2026-09-18T14:43:59Z

        <View style={[styles.p4, styles.flexRow, styles.flexWrap, styles.gap4]}>
+            <SectionHeading title="Phase 4 — title styles">numberOfLinesTitle became numberOfLines on the text leaves.</SectionHeading>
+
+            <Card


hmmm not sure what's going on with Card, but I assume it's been discussed somewhere and is a temporary state of affairs

oh, I probably should have named it differently 😅 But it is just a section comparing usages

OSBotify · 2026-09-18T14:49:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-18T14:57:06Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-09-18T15:00:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #101225.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e66b879-7288901-96942956bddc3ed0c7ebd4388cfb586cb24ba2d9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e66b879-7288901-0dca4e412f671b5dab721bc89637abf6e891b191/index.html

Web 🕸️
https://101225.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-18T20:20:13Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.90-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-18T20:24:05Z

🤖 No help site changes are required — no draft PR created.

This PR is an internal component refactor. It migrates MenuItemWithTopDescription callsites to the MenuItemField preset and adds a numberOfLines / numberOfLinesValue prop so field values can wrap. Nothing a help article documents changes.

Why I concluded no docs impact

I checked the diff against the three things that would force a docs/articles update — changed copy, changed navigation, and changed feature behavior:

No copy changes. No src/languages/*.ts file is in the diff. Every label in the diff (common.destination, iou.taxAmount, travel.carDetails.cancellation, workspace.moreFeatures.companyCards.cardFeedName, workspace.reportFields.listValues, and the rest) is an existing translation key that only moved from the description/title props to the preset's name/value props. The rendered strings are byte-identical.
No navigation or entry-point changes. Every onPress keeps its existing route. The refactor rewrites interactive/shouldShowRightIcon into the preset's onPress-presence convention, which is the same behavior expressed differently.
No feature behavior changes. The only user-visible differences are presentational: long field values now wrap and clamp (2 lines on Cancellation, Category, Date, Tax, Report, Address, Trip, Time; 5 lines on List values) instead of truncating on one line. Help articles describe what a field is for, not how many lines it renders on.
The one behavior fix is a bug fix, not a documented behavior. src/pages/ShareCodePage.tsx rebuilds the Download row with composable MenuItem parts so an anonymous user downloading a QR code is no longer signed out. The help site documents that you can download a QR code — it never documented the sign-out, which was the bug.

I searched docs/articles for content tied to these rows and found nothing that describes field truncation, row layout, or the MenuItem component. There is no article whose accuracy this PR affects.

If you'd like a docs update anyway for something I read as purely presentational — for example if the List values wrapping is meant to be called out in the Report fields article — reply with @MelvinBot and the article you have in mind and I'll open the draft PR.

@war-in, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run

war-in added 7 commits September 15, 2026 15:45

feat: add numberOfLines support to MenuItemTitle and Value

940b024

refactor: migrate MenuItem callsites that set numberOfLinesTitle

8b9b9b2

test: add tests for numberOfLinesValue

73be721

refactor: migrate callsites that used dead `styles.moneyRequestMenuIt…

561a695

…em` & `styles.flex1`

test: fix TimeExpenseConfirmationTest.tsx after migration

c1427c8

refactor: migrate to composable API

3e7bd13

refactor: migrate to composable API

a488a1c

melvin-bot Bot assigned war-in Sep 15, 2026

war-in added 2 commits September 15, 2026 18:02

chore: add comparison

ef8201f

test: remove unnecessary mocks

93390d3

war-in marked this pull request as ready for review September 15, 2026 16:19

war-in requested review from a team as code owners September 15, 2026 16:19

melvin-bot Bot requested review from Pujan92 and trjExpensify and removed request for a team September 15, 2026 16:19

melvin-bot Bot removed the request for review from a team September 15, 2026 16:19

trjExpensify removed their request for review September 15, 2026 19:05

MelvinBot mentioned this pull request Sep 16, 2026

MenuItem — composition over configuration #96202

Open

war-in added 2 commits September 17, 2026 16:10

Merge branch 'main' into war-in/menuitem-decomposition-title-styles

b6391e9

# Conflicts: # src/pages/workspace/fields/CreateFieldsPage.tsx # src/pages/workspace/fields/FieldsValueSettingsPage.tsx

Merge branch 'main' into war-in/menuitem-decomposition-title-styles

4dd3d01

# Conflicts: # src/components/MoneyRequestConfirmationList/sections/PerDiemFields.tsx # src/stories/MenuItemComparison.stories.tsx

Pujan92 approved these changes Sep 18, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 18, 2026 13:43

roryabraham approved these changes Sep 18, 2026

View reviewed changes

roryabraham merged commit e66b879 into Expensify:main Sep 18, 2026
35 of 37 checks passed

OSBotify mentioned this pull request Sep 18, 2026

Deploy Checklist: New Expensify 2026-09-18 #101620

Open

61 tasks

Navigation Menu

MenuItem decomposition - titleStyle migration - #101225

MenuItem decomposition - titleStyle migration#101225
roryabraham merged 11 commits into
Expensify:mainfrom
software-mansion-labs:war-in/menuitem-decomposition-title-styles

war-in commented Sep 15, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Sep 15, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Sep 15, 2026

Uh oh!

trjExpensify commented Sep 15, 2026

Uh oh!

Pujan92 commented Sep 18, 2026 •

edited

Loading

Uh oh!

Pujan92 left a comment

Uh oh!

roryabraham Sep 18, 2026

Uh oh!

war-in Sep 18, 2026

Uh oh!

Uh oh!

OSBotify commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

OSBotify commented Sep 18, 2026

Uh oh!

MelvinBot commented Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

war-in commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Sep 15, 2026

Uh oh!

trjExpensify commented Sep 15, 2026

Uh oh!

Pujan92 commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

war-in Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

OSBotify commented Sep 18, 2026

Uh oh!

MelvinBot commented Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

war-in commented Sep 15, 2026 •

edited

Loading

codecov Bot commented Sep 15, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented Sep 18, 2026 •

edited

Loading